Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added default fallback for selectedColumns, when the attributeKeys call gives empty #5847

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Sep 4, 2024

Summary

Added default fallback for selectedColumns, when the attributeKeys call gives empty due to ttl i.e. 2days is reached.

Due to this dependency on the api response we get selected columns as empty (in case where localstorage variable - Trace_list_option is also not present) hence we need a fallback to show atleast the default signoz provided column otherwise user don't see data at all.

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/1459

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

github-actions bot commented Sep 4, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

github-actions bot commented Sep 4, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 4214e36 into develop Sep 6, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-1459 branch September 6, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants