Skip to content

fix: integration token refresh test reads cookie instead of JSON body #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Senthil455 merged 1 commit into from
Jun 17, 2026
Merged

fix: integration token refresh test reads cookie instead of JSON body #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tests/integration/run-integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,16 @@ else
fi
fi

COOKIE_JAR=$(mktemp)

TESTS+=("Login with valid credentials")
LOGIN_RES=$(curl -sf -X POST "$AUTH_URL/login" \
-H 'Content-Type: application/json' \
-c "$COOKIE_JAR" \
-d '{"email":"admin@atlas.io","password":"ChangeMe123!"}') || { report_fail "Login with valid credentials"; LOGIN_RES=""; }

if [ -n "$LOGIN_RES" ]; then
TOKEN=$(echo "$LOGIN_RES" | python3 -c "import sys,json; print(json.load(sys.stdin)['token'])" 2>/dev/null) || TOKEN=""
REFRESH_TOKEN=$(echo "$LOGIN_RES" | python3 -c "import sys,json; print(json.load(sys.stdin)['refreshToken'])" 2>/dev/null) || REFRESH_TOKEN=""
USER_ID=$(echo "$LOGIN_RES" | python3 -c "import sys,json; print(json.load(sys.stdin)['user']['id'])" 2>/dev/null) || USER_ID=""
if [ -n "$TOKEN" ]; then
report_pass "Login with valid credentials"
Expand All @@ -125,10 +127,11 @@ else
fi

TESTS+=("Token refresh")
if [ -n "$REFRESH_TOKEN" ]; then
if [ -s "$COOKIE_JAR" ] && grep -q "refreshToken" "$COOKIE_JAR" 2>/dev/null; then
REFRESH_RES=$(curl -sf -X POST "$AUTH_URL/refresh" \
-H 'Content-Type: application/json' \
-d "{\"refreshToken\":\"$REFRESH_TOKEN\"}") || REFRESH_RES=""
-b "$COOKIE_JAR" \
-c "$COOKIE_JAR") || REFRESH_RES=""
NEW_TOKEN=$(echo "$REFRESH_RES" | python3 -c "import sys,json; print(json.load(sys.stdin)['token'])" 2>/dev/null) || NEW_TOKEN=""
if [ -n "$NEW_TOKEN" ]; then
report_pass "Token refresh"
Expand All @@ -137,9 +140,11 @@ if [ -n "$REFRESH_TOKEN" ]; then
report_fail "Token refresh"
fi
else
report_fail "Token refresh — no refresh token"
report_fail "Token refresh — no refresh token cookie"
fi

rm -f "$COOKIE_JAR"

# ────────────────────────────────────────────────────────────────────────────
# 3. Employee CRUD Flow
# ────────────────────────────────────────────────────────────────────────────
Expand Down
Loading