fix: integration token refresh test reads cookie instead of JSON body - #91
Merged
Senthil455 merged 1 commit intoJun 17, 2026
Merged
Conversation
…e instead of JSON body The refresh token is set as an httpOnly cookie by the auth service, but the integration test was trying to extract it from the JSON response body, which never contained it. The test silently fell through with an empty string and always reported failure. Fix: use curl -c/-b cookie jar to capture the Set-Cookie header from the login response and send it back in the refresh request, matching how the auth service actually handles refresh tokens.
Senthil455
reviewed
Jun 17, 2026
Senthil455
left a comment
Owner
There was a problem hiding this comment.
gh: Not Found (HTTP 404)
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Problem
The integration test assumed the refresh token was returned in the login JSON response body. But the auth service sets it as an httpOnly cookie (auth-service/index.js:713-718) and the /refresh endpoint reads from req.cookies (auth-service/index.js:744).
Lines 106 and 129-131 of run-integration-tests.sh:
Fix
Testing
The token refresh test now: