Repository navigation
Conversation
Contributor
|
Thanks for the contribution!
中文感谢你的贡献!
|
This was referenced Oct 8, 2026
Draft
adibarra
added this pull request to stack #3808
October 8, 2026 14:35
adibarra
force-pushed
the
refactor/srt-bound-versions
branch
from
October 8, 2026 16:03
c889163 to
2e36885
Compare
adibarra
force-pushed
the
refactor/srt-bound-versions
branch
4 times, most recently
from
October 8, 2026 23:04
982ad1d to
1fc1213
Compare
adibarra
force-pushed
the
refactor/srt-bound-versions
branch
2 times, most recently
from
October 9, 2026 17:47
0f3b14e to
a11b62a
Compare
adibarra
force-pushed
the
refactor/srt-bound-versions
branch
2 times, most recently
from
October 9, 2026 18:48
0451f3a to
f2ad832
Compare
adibarra
force-pushed
the
refactor/srt-bound-versions
branch
2 times, most recently
from
October 10, 2026 07:51
ba3bc93 to
a024ca8
Compare
…er config Repo setup scripts that install a component now read its version from the recipe instead of pinning it, and the binder writes the point's master version after variant selection, so the submitted recipe shows what gets installed: - vllm-router.sh (was vllm-router-0.1.14.sh) reads ROUTER_VERSION. - vllm-mooncake.sh (was vllm-mooncake-0.3.11.sh) reads KV_OFFLOAD_BACKEND_VERSION; kimik3-b300-mooncake.sh and the mooncake-master preambles of the Kimi-K3 B300 and MiniMax-M3 H100 recipes run it instead of pinning their own pip install. - lmcache-mp-rocm.sh reads KV_OFFLOAD_BACKEND_VERSION. - glm5.3-tilert-rocm.sh reads ROUTER_VERSION, the tilert-pd-router release; the GLM-5.3 recipe drops TILERT_VERSION. The binder writes the version into the top-level environment when setup_script is one of these installers (workers and static routers) and into the env of each service whose preamble runs one, since services do not inherit environment. A point that does not declare the version fails before submission, a vllm-router pin in SETUP_PIP_PACKAGES must match the master router, and a fragment may not set the version variables. The launcher and infx generate also fail a bound recipe whose setup_script is in neither configs/ nor the srt-slurm checkout's, where srtctl itself only warns.
The router half of the binding test reruns the setup_script branch the Mooncake half covers, the pinned-router acceptance only echoed its input, and the setup-script check is called directly instead of through a copy of the multi-node CLI harness.
_fragment_versions yields like _dram_literals and reads TEXT_MAPPINGS, the one-entry PIP_COMPONENTS registry becomes the vllm-router check it was, and lmcache-mp-rocm.sh reads KV_OFFLOAD_BACKEND_VERSION without an alias.
adibarra
force-pushed
the
refactor/srt-bound-versions
branch
from
October 10, 2026 13:38
a024ca8 to
2aeeef9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Component versions that repo scripts install now come from the master config, not hardcoded pins.
check_env_vars, with no defaults:vllm-router.sh, renamed fromvllm-router-0.1.14.sh; readsROUTER_VERSION.vllm-mooncake.sh, renamed fromvllm-mooncake-0.3.11.shand now also called bykimik3-b300-mooncake.shand the mooncake-master preambles; readsKV_OFFLOAD_BACKEND_VERSION.lmcache-mp-rocm.sh; readsKV_OFFLOAD_BACKEND_VERSION.glm5.3-tilert-rocm.sh; readsROUTER_VERSION, replacing the recipe'sTILERT_VERSION.set -eo pipefail.router/kv-offload-backendversion into each place the install runs: top-levelenvironmentfor setup scripts, andservices[].envfor preambles that run an installer.SETUP_PIP_PACKAGESvllm-router==pin is left in place and checked against the master version.setup_scriptcheck: asetup_scriptthat resolves to no file inconfigs/(ours or the submodule's) now fails at launch and ininfx generate. Upstream srtctl only warns.CONFIGS.mdandRECIPES.mdupdated.Verification
setup_scriptin 74 recipes,ROUTER_VERSIONadded in 70,KV_OFFLOAD_BACKEND_VERSIONadded in 42, mooncake preamble changed in 39, and GLM-5.3TILERT_VERSIONreplaced byROUTER_VERSION.python3, run identical pip commands base vs head except:--quiet;MooncakeDistributedStoreimport check that worker installs already run.No hardware smoke yet. One MI300X LMCache point and one Kimi-K3 B300 point would cover the script and service paths.