Repository navigation
Conversation
A perf-changelog.yaml entry is what triggers result collection, so add one only when a change should produce new published results. Refactors and recipe or config edits that are not meant to produce new results need no entry. Reword the old rule that every performance-affecting change and every recipe addition or modification needs an entry in AGENTS.md, CONTRIBUTING.md, the multi-node RECIPES.md guide, the PR template, and the Claude workflow prompts. The review prompt no longer blocks a PR that edits master configs without an entry; it asks, without blocking, whether the author intends to collect results. The append-only byte rules, one block per PR, English-only entries, and append-only: true semantics are unchanged.
Contributor
|
Thanks for the contribution!
中文感谢你的贡献！
|
This was referenced Oct 8, 2026
Draft
State the rule in one sentence: add an entry only when the change should produce new published results, not for every recipe or config edit. Trim the review prompt's non-blocking instructions. The Chinese pages mirror the English text.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
perf-changelog.yamlentry is what triggers result collection, so add one only when a change should produce new published results. Refactors and recipe or config edits that are not meant to produce new results need no entry.Changed:
AGENTS.md,CONTRIBUTING.md,RECIPES.md: state the new rule. The append-only, byte-sensitive and tail-only rules, one block per PR, English-only entries andappend-only: truesemantics are unchanged.claude.yml: the coding job adds an entry only when results are wanted, and asks when that is unclear. In the review job, a master-config edit without an entry is no longer blocking; the bot asks once whether the author intends to collect results.Not changed: CODEOWNER sign-off Check 1 and
PR_REVIEW_CHECKLIST.mdstill require a green sweep before sign-off. Changing that merge standard is a separate decision.