test(semantic): update the storage tests to reflect new semantics#130
Draft
test(semantic): update the storage tests to reflect new semantics#130
Conversation
We updated the semantics of confidential storage opcodes in SeismicSystems/seismic-revm#180. The changes here are needed to reflect the new semantics.
samlaf
added a commit
to SeismicSystems/seismic-revm
that referenced
this pull request
Jan 22, 2026
See committed README changes for explanation of new semantics. TLDR is that we are implementing these new semantics, after some audit discussions. | | (0, public) | (x, public) | (0, private) | (x, private) | | --------- | ------------ | ----------- | ------------ | ------------ | | SLOAD | 0 | x | HALT | HALT | | CLOAD | 0 | x | 0 | x | | SSTORE(y) | (y, public) | (y, public) | HALT | HALT | | CSTORE(y) | (y, private) | HALT | (y, private) | (y, private) | ## Note Had to update CI semantic tests to point to SeismicSystems/seismic-solidity#130 in order to fix tests. We should change back CI once that PR merges after audit. Added a note in that PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
We would ideally want to merge this, but we are ongoing audits in this repo, and don't want to merge to seismic branch while that is ongoing. We will merge this after audits are done.
We updated the semantics of confidential storage opcodes in SeismicSystems/seismic-revm#180. The changes here are needed to reflect the new semantics.
Note
Whoever merges this should go and fix the CI in seismic-revm to point back to checking out the seismic branch of this repo, instead of this branch (test--new-storage-opcode-semantics).