Skip to content

chore:update rng precompile semantic test#205

Open
daltoncoder wants to merge 1 commit intotest--new-storage-opcode-semanticsfrom
update-precompile-semantic-test
Open

chore:update rng precompile semantic test#205
daltoncoder wants to merge 1 commit intotest--new-storage-opcode-semanticsfrom
update-precompile-semantic-test

Conversation

@daltoncoder
Copy link

No description provided.

Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just to make sure I understand, why is this being merged into my PR's branch?

And I'm confused as to which version of seismic-revm this is even running against. Is this related to your RNG changes? Are we sure we're going to merge those? Feel like we should only merge this once we've merged the RNG changes on revm side..?

@cdrappi
Copy link
Contributor

cdrappi commented Feb 17, 2026

@samlaf some context on motivation:

  • your branch is the seismic-solidity branch we point revm against for semantic tests. Basically I told Dalton that he should build revm against this branch
  • as of yesterday Dalton has figured out the RNG changes and these tests reflect the new behaviour

Unclear what the best way to proceed git hygiene wise (e.g. should we make a clearer-named branch that has both of these changes?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants