Add support for x86 devices #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetersson
approved these changes
Sep 5, 2024
ansible/roles/system/tasks/main.yml
Outdated
| @@ -206,15 +209,28 @@ | |||
| update_cache: true | |||
| when: not cdefs_exist | |||
|
|
|||
| - name: Install Anthias dependencies | |||
| - name: Get architecture | |||
| ansible.builtin.command: dpkg --print-architecture | |||
There was a problem hiding this comment.
Use a more native way for this. You can get it from ansible directly.
The long term plan is to be less Debian specific so the less hard coded we can be the better.
There was a problem hiding this comment.
@nicomiguelino this is what I mean
Meaning, use "ansible_facts.ansible_architecture" instead of shelling out.
There was a problem hiding this comment.
Got it, thanks! Please see newer commits.
nicomiguelino
commented
Sep 5, 2024
* Some code are still hardcoded. * Proper fixes will be committed later.
vpetersson
reviewed
Sep 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References (for Easy Access)