Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new Ansible tag for Pi-related steps #2052

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Add a new Ansible tag for Pi-related steps #2052

merged 2 commits into from
Sep 4, 2024

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Sep 4, 2024 •
edited
Loading

Description

  • Added a new Ansible tag called raspberry-pi
  • Renamed the tag touches_boot_partition to touches-boot-partition for consistency
  • Added the touches-boot-partition to steps that need it
  • This pull request can slim down changes made in Add support for x86 devices #2048.

@nicomiguelino nicomiguelino requested a review from a team as a code owner September 4, 2024 15:10
vpetersson
vpetersson approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - but let's fix the linting.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nicomiguelino nicomiguelino merged commit 07713c3 into Screenly:master Sep 4, 2024
6 checks passed
@nicomiguelino nicomiguelino deleted the add-ansible-tags-for-pi branch September 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson