-
Notifications
You must be signed in to change notification settings - Fork 279
feat(ui5-button): Add BusyIndicator #11906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
0e0d4d1
feat: add busy indicator in ui5-button
GDamyanov 3a26280
feat: add opacity background to buttom when loading
GDamyanov 79e70aa
Merge branch 'main' into button-busy-indicator
GDamyanov f14d013
feat: stype opacity on busy indicator in button
GDamyanov b805686
Merge branch 'button-busy-indicator' of https://github.com/SAP/ui5-we…
GDamyanov b9964b0
Merge branch 'main' into button-busy-indicator
GDamyanov 1962be2
refactor: remove tabs
GDamyanov b692a21
Merge branch 'button-busy-indicator' of https://github.com/SAP/ui5-we…
GDamyanov 7b6b898
refactor: remove tabs
GDamyanov ae4bc15
refactor: update text
GDamyanov 1475f14
Merge branch 'main' into button-busy-indicator
GDamyanov 3ef3b12
Merge branch 'main' into button-busy-indicator
GDamyanov bdf1e56
Update packages/main/src/Button.ts
GDamyanov 6526dca
fix: remove redundant tooltip
GDamyanov b386727
feat: add loadingDelay property
GDamyanov 5c0344e
Merge branch 'main' into button-busy-indicator
GDamyanov 54636c4
Merge branch 'main' into button-busy-indicator
GDamyanov 1258347
refactor: update jsdoc
GDamyanov 420238c
Merge branch 'button-busy-indicator' of https://github.com/SAP/ui5-we…
GDamyanov 44a4d02
Merge branch 'main' into button-busy-indicator
GDamyanov bfd6ae1
Merge branch 'main' into button-busy-indicator
GDamyanov c8dc14d
Merge branch 'main' into button-busy-indicator
GDamyanov a4c0ab1
Merge branch 'main' into button-busy-indicator
GDamyanov 7b1d828
Merge branch 'main' into button-busy-indicator
GDamyanov af1109d
feat: add sample in playground
GDamyanov 2d4d825
Merge branch 'button-busy-indicator' of https://github.com/SAP/ui5-we…
GDamyanov 96ae6d5
Merge branch 'main' into button-busy-indicator
GDamyanov 17fd6ba
Merge branch 'main' into button-busy-indicator
GDamyanov cc36fbb
fix: update jsdocs
GDamyanov 8de3c62
Merge branch 'button-busy-indicator' of https://github.com/SAP/ui5-we…
GDamyanov 9c51de8
Merge branch 'main' into button-busy-indicator
GDamyanov 0cf7af8
Merge branch 'main' into button-busy-indicator
GDamyanov ab323c3
Merge branch 'main' into button-busy-indicator
GDamyanov bcec2e3
fix: move to the next element by clicking tab
GDamyanov 30f118c
Merge branch 'button-busy-indicator' of https://github.com/SAP/ui5-we…
GDamyanov 927a05c
fix: border issues, tab click fix and add test
GDamyanov 3440544
refactor: remove empty lines
GDamyanov a4e19d7
Merge branch 'main' into button-busy-indicator
GDamyanov f58d5d3
Merge branch 'main' into button-busy-indicator
GDamyanov f81c21a
Merge branch 'main' into button-busy-indicator
GDamyanov 717f480
fix: use enum for size instead of strings
GDamyanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/website/docs/_samples/main/Button/Loading/Loading.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import html from '!!raw-loader!./sample.html'; | ||
import js from '!!raw-loader!./main.js'; | ||
|
||
<Editor html={html} js={js} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import "@ui5/webcomponents/dist/Button.js"; | ||
|
||
import "@ui5/webcomponents-icons/dist/edit.js"; | ||
import "@ui5/webcomponents-icons/dist/employee.js"; |
32 changes: 32 additions & 0 deletions
32
packages/website/docs/_samples/main/Button/Loading/sample.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
<!-- playground-fold --> | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
|
||
<head> | ||
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Sample</title> | ||
</head> | ||
|
||
<body style="background-color: var(--sapBackgroundColor)"> | ||
<!-- playground-fold-end --> | ||
<div> | ||
<br/> | ||
<ui5-button icon="sap-icon://edit" tooltip="Accept terms & conditions" loading></ui5-button> | ||
<ui5-button loading>Loading</ui5-button> | ||
<ui5-button icon="sap-icon://employee" loading>Loading</ui5-button> | ||
<ui5-button design="Transparent" loading>Loading</ui5-button> | ||
<ui5-button icon="sap-icon://employee" design="Transparent" loading>Loading</ui5-button> | ||
<ui5-button design="Emphasized" loading>Loading</ui5-button> | ||
<ui5-button icon="sap-icon://employee" design="Emphasized" loading>Loading</ui5-button> | ||
<ui5-button design="Positive" loading>Loading</ui5-button> | ||
<ui5-button icon="sap-icon://employee" design="Positive" loading>Loading</ui5-button> | ||
<ui5-button design="Negative" loading>Loading</ui5-button> | ||
<ui5-button icon="sap-icon://employee" design="Negative" loading>Loading</ui5-button> | ||
</div> | ||
<!-- playground-fold --> | ||
<script type="module" src="main.js"></script> | ||
</body> | ||
|
||
</html> | ||
<!-- playground-fold-end --> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.