feat(ui5-button): Add BusyIndicator #11906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bcomponents into button-busy-indicator
…bcomponents into button-busy-indicator
hinzzx
requested changes
Jul 15, 2025
hinzzx
approved these changes
Jul 17, 2025
hinzzx
reviewed
Jul 17, 2025
…bcomponents into button-busy-indicator
Stoev
reviewed
Jul 21, 2025
| */ | ||
| @property({ type: Number }) | ||
| loadingDelay = 1000; | ||
|
|
||
| /** | ||
| * The current title of the button, either the tooltip property or the icons tooltip. The tooltip property with higher prio. | ||
| * @private |
There was a problem hiding this comment.
Please consider paraphrasing:
The button's current title is determined by either the tooltip property or the icon's tooltip, with the tooltip property taking precedence if both are set.
packages/main/src/Button.ts
Outdated
| /** | ||
| * Defines whether the button shows a loading indicator. | ||
| * | ||
| * **Note:** If set to `true` a busy indicator component will be displayed into the related button. |
There was a problem hiding this comment.
Please consider:
Note: If set to true, a busy indicator component will be displayed on the related button.
Stoev
reviewed
Jul 21, 2025
packages/main/src/Button.ts
Outdated
| loading = false; | ||
|
|
||
| /** | ||
| * Defines the delay in milliseconds, after which the loading indicator will be displayed inside the related button. |
There was a problem hiding this comment.
Please consider:
Specifies the delay in milliseconds before the loading indicator appears within the associated button.
If you prefer to keep the text as is, please remove the comma:
Defines the delay in milliseconds after which the loading indicator will be displayed inside the related button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BusyIndicator to the button