Skip to content

chore: update win patches #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 21, 2025
Merged

chore: update win patches #51

merged 12 commits into from
Apr 21, 2025

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 19, 2025

No description provided.

@wep21 wep21 changed the title chore: remove moveit planners stomp win patch chore: remove moveit win patches Apr 19, 2025
@wep21
Copy link
Contributor Author

wep21 commented Apr 19, 2025

@Tobias-Fischer @traversaro This is a follow up PR to fix windows ci.

@wep21
add win patch
7c4db39 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 force-pushed the remove-moveit-stomp-win-patch branch from 4aee50f to 7c4db39 Compare April 19, 2025 15:04
wep21 added 5 commits April 20, 2025 12:18
@wep21
remove win patch
7c01a5d 
Signed-off-by: wep21 <[email protected]>
@wep21
update win patch
f6673fa 
Signed-off-by: wep21 <[email protected]>
@wep21
update win patch
46e65f7 
Signed-off-by: wep21 <[email protected]>
@wep21
update win patch
0a77a01 
Signed-off-by: wep21 <[email protected]>
@wep21
add win patch
8f4f3e1 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 force-pushed the remove-moveit-stomp-win-patch branch from 8f11e74 to 8f4f3e1 Compare April 20, 2025 13:44
@wep21
Copy link
Contributor Author

wep21 commented Apr 20, 2025

@Tobias-Fischer @traversaro ci is now green. I appreciate it if you could review this PR.

@traversaro
Copy link
Member

@Tobias-Fischer @traversaro ci is now green. I appreciate it if you could review this PR.

Thanks a lot for the hard work!

traversaro
traversaro approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, we can also change this is a follow up PR.

@wep21
update win patch
adb81ff 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 changed the title chore: remove moveit win patches chore: update win patches Apr 21, 2025
@wep21 wep21 requested a review from traversaro April 21, 2025 06:31
@Tobias-Fischer
Copy link
Contributor

Thanks a lot this looks great!

@Tobias-Fischer Tobias-Fischer merged commit 9155338 into RoboStack:main Apr 21, 2025
5 checks passed
@wep21 wep21 deleted the remove-moveit-stomp-win-patch branch April 21, 2025 08:47
@traversaro
Copy link
Member

@Tobias-Fischer @traversaro ci is now green. I appreciate it if you could review this PR.

Thanks a lot for the hard work!

To elaborate a bit more, this was hard to do, so thanks again to @wep21 . The upside is that most failures were due to Windows-related patches that were kindly merged by moveit and ros_control mantainers, so hopefully the effort required would be less in the future (also, solving RoboStack/robostack.github.io#72 may also help).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro Awaiting requested review from traversaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wep21 @traversaro @Tobias-Fischer