Skip to content

Conversation

wentywenty
Copy link
Contributor

Fixes Windows-specific compilation issues

@wentywenty
Copy link
Contributor Author

Run ls output/emscripten-wasm32
ls output/emscripten-wasm32
shell: /usr/bin/bash -l {0}
env:
ROS_VERSION: 2
SAVE_CACHE_AS_ARTIFACT: false
ls: cannot access 'output/emscripten-wasm32': No such file or directory
Error: Process completed with exit code 2.

This error in the sixth item of GitHub cil, do I need to modify any other files?

@wentywenty
Copy link
Contributor Author

0s
Run pixi run python check_patches_clean_apply.py
pixi run python check_patches_clean_apply.py
shell: /usr/bin/bash -l {0}
env:
ROS_VERSION: 2
SAVE_CACHE_AS_ARTIFACT: false
No recipes with patches found – nothing to test.
1s
Run actions/cache/restore@v4
with:
path: output/emscripten-wasm32

key: Linux-emscripten-wasm32-pr-330
restore-keys: Linux-emscripten-wasm32-pr-330-

enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false

env:
ROS_VERSION: 2
SAVE_CACHE_AS_ARTIFACT: false
Cache not found for input keys: Linux-emscripten-wasm32-pr-330, Linux-emscripten-wasm32-pr-330-
0s
Run ls output/emscripten-wasm32
ls output/emscripten-wasm32
shell: /usr/bin/bash -l {0}
env:
ROS_VERSION: 2
SAVE_CACHE_AS_ARTIFACT: false
ls: cannot access 'output/emscripten-wasm32': No such file or directory
Error: Process completed with exit code 2.
0s
0s
0s
Run ls output/emscripten-wasm32
ls: cannot access 'output/emscripten-wasm32': No such file or directory
Error: Process completed with exit code 2.

@wentywenty
Copy link
Contributor Author

This should not be my PR issue.

@traversaro
Copy link
Member

Yes, that is a bug in the PR logic, feel free to ignore, thanks! Anyhow, yo ensure that the package is actually built, you need to increase its build number in https://github.com/RoboStack/ros-humble/blob/main/pkg_additional_info.yaml, and raise the build number in the comment in

# Reminder for next full rebuild, the next build number should be 14
to ensure that on next rebuild we raise the build number to 15.

@wentywenty
Copy link
Contributor Author

Yes, that is a bug in the PR logic, feel free to ignore, thanks! Anyhow, yo ensure that the package is actually built, you need to increase its build number in https://github.com/RoboStack/ros-humble/blob/main/pkg_additional_info.yaml, and raise the build number in the comment in

# Reminder for next full rebuild, the next build number should be 14

to ensure that on next rebuild we raise the build number to 15.

Okay.

@wentywenty
Copy link
Contributor Author

Do I need to modify the build number in pkg_additional_info.yaml and the comments in vinca.yaml according to your instructions?

Yes, that is a bug in the PR logic, feel free to ignore, thanks! Anyhow, yo ensure that the package is actually built, you need to increase its build number in https://github.com/RoboStack/ros-humble/blob/main/pkg_additional_info.yaml, and raise the build number in the comment in

# Reminder for next full rebuild, the next build number should be 14

to ensure that on next rebuild we raise the build number to 15.

@traversaro
Copy link
Member

Ah, my bad, I was confused by the title of the PR, if the package was not built before there is no need to bump the build number.

@traversaro traversaro merged commit 88e984e into RoboStack:main Jul 29, 2025
5 of 6 checks passed
@wentywenty
Copy link
Contributor Author

Ah, my bad, I was confused by the title of the PR, if the package was not built before there is no need to bump the build number.

Thank you!

@traversaro
Copy link
Member

@wentywenty Thanks you for the PR! In case you are interested in this, it may be useful to also propose the change you added here in https://github.com/CCNYRoboticsLab/imu_tools, so that we reduce the amount of patches we maintain locally here, see RoboStack/robostack.github.io#16 for issue on this effort in general.

@wentywenty
Copy link
Contributor Author

@traversaro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants