CI Hotfix when none packages where built #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can’t we just do the opposite and only not skip if the platform is emscripten? |
|
What do you think @traversaro? |
Yes, I think it could make sense to have a |
|
Thanks @nmarticorena - do you know of an equivalent on Windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CI is failing due to the additional recipes added for emscripten, which are skipped by rattler-build, resulting in the CI failing due to having an empty output folder.
This pr is a hotfix to check first if anything was built before attempting to upload it, this will effectively fix https://github.com/RoboStack/ros-humble/actions/runs/14767448589
A better approach would be to check in vinca generate_gha to implement a parse skip, in https://github.com/RoboStack/vinca/blob/9eb0b36b3cb673f6ab0789dd22f06668ccae5fd3/vinca/generate_gha.py#L197 , but I couldn't find the whole list of possible names for the platforms that rattler-build takes