-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add livox ros driver2 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wep21 <[email protected]>
@traversaro @Tobias-Fischer How can I build additional recipe in ci? What do you think about adding a package which is not on rosdistro into robostack channel? |
I am not an expert of those (ideally it would be great if they were generated togetehr with other recipes, just from other data, not coming from rosdistro) but I guess the PR in https://github.com/RoboStack/ros-humble/pull/268/files#diff-069a2e75bc939d92ad32a50dada65893abaf603c1a586b97183ec1ca476bba23R148 could provide useful hints.
As long as it the motivation is quite clear (and in that case I see the reason) no problem for me. |
I will try something.
The motivations is that livox mid360 sensor is quite popular in slam realm while livox ros driver is not well maintained by DJI and seems to be never added into rosdistro unfortunately. |
77b3a6f
to
a4448cd
Compare
eebebb4
to
e060d3c
Compare
717e637
to
830c6f9
Compare
Signed-off-by: wep21 <[email protected]>
@traversaro @Tobias-Fischer I appreciate it if you could review this PR now. The platforms where livox driver is built are only linux. |
What do you think about copying the selected additional recipes into the recipes folder? I think this would avoid some duplication. Otherwise this looks great thanks a lot!! |
Signed-off-by: wep21 <[email protected]>
@traversaro @Tobias-Fischer I've addressed the review. Please check the change again. |
Side note @traversaro - with now noetic, humble and jazzy our repositories somewhat diverge, we should think whether there is a way to better handle this. |
Hi, as an additional side note, this problem is quite similar to the issue we are currently having on ros-humble RoboStack/ros-humble#296 due to the emscripten recipes, as I can see here, the additional recipes still trigger the CI win example due to the vinca_gha only checks if the package is already available in the channel. My two cents will be to solve this problem from Vinca by adding a parse skip, and we can ease up by adding a note in the docs on how to write the platforms to skip, so then we dont need to implement for all viable skip syntax allowed by rattler. |
livox ros driver is not on rosdistro, so I've added it as additional recipe.