-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Internal support for draft paywall previews #4761
Merged
+343
−5
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
aa71bd3
feat: add support for presenting draft paywalls under `@_spi(Internal…
ajpallares 29cbdd6
fix: initialize `useDraftPaywall` property of `PaywallView`
ajpallares 528312f
feat: have `PaywallView` actually show draft paywall when `useDraftPa…
ajpallares e45cfab
remove lint warning
ajpallares ee2d83e
silence linter warning
ajpallares 9911169
Merge branch 'main' into uiPreviewMode/paywall-drafts
ajpallares 39f56e8
Merge branch 'main' into uiPreviewMode/paywall-drafts
ajpallares 065fbee
tests: add unit tests for `paywallComponents` and `draftPaywallCompon…
ajpallares 4dad9bf
tests: move test offerings with v2 paywalls into a new file not to af…
ajpallares 92a4bf9
remove unnecessary property wrapper
ajpallares caa5b41
silence lint warning
ajpallares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk if we should be documenting these public-but-not-public APIs 🤔 WDYT @RevenueCat/coresdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm IMO, I think it's fine to not document them. It's not meant for public usage yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more inclined to documenting since it's quick, and particularly adding a
- warn: this API is meant for internal use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure... I would actually hide them from the reference docs if possible, but maybe we should have a note for people finding it through autocomplete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't appear in the autocomplete because of the
@_spi(Internal)
attribute. And based on the existing v5.16.1 release, which contains@_spi
-protected APIs inDangerousSettings
, it does not appear in the reference docs either (see https://revenuecat.github.io/purchases-ios-docs/5.16.1/documentation/revenuecat/dangeroussettings)@aboedo for all the above, I think that we don't need to document this and that its being internal should be clear thanks to
@_spi(Internal)
attribute