Add Internal support for draft paywall previews #4761
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
commented
Feb 7, 2025
| ) | ||
| } | ||
|
|
||
| // swiftlint:disable:next missing_docs |
There was a problem hiding this comment.
Idk if we should be documenting these public-but-not-public APIs 🤔 WDYT @RevenueCat/coresdk?
There was a problem hiding this comment.
Hmm IMO, I think it's fine to not document them. It's not meant for public usage yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation
We need a way to show paywalls in the draft state for the Paywall Previews functionality in the RC app
Description
Adds some new
@_spi-protected public APIs regarding draft paywalls:*
draftPaywallComponentsproperty inOffering, to know if there's a draft paywall available.* A new
initinPaywallViewthat adds theuseDraftPaywallparameter to show the draft paywall instead of the published one.