Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin Vale in GitHub action to last v2 vale version until we update to v3 #1387

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

lornajane
Copy link
Contributor

What/Why/How?

Vale has a new release (yay!) but it came with some directory structure changes and these are causing the build to fail. This pull request pins to a working version and I'll follow up with another one to handle the v3 update.

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@lornajane lornajane requested a review from a team as a code owner January 10, 2024 11:44
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 38d07b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.066 ± 0.033 1.034 1.149 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.070 ± 0.015 1.042 1.092 1.00 ± 0.03

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.31% 4100/5373
🟡 Branches 66.29% 2183/3293
🟡 Functions 68.42% 663/969
🟡 Lines 76.51% 3847/5028

Test suite run success

671 tests passing in 94 suites.

Report generated by 🧪jest coverage report action from 38d07b8

@lornajane lornajane mentioned this pull request Jan 10, 2024
5 tasks
@lornajane lornajane merged commit f1eb654 into main Jan 10, 2024
29 checks passed
@lornajane lornajane deleted the pin-vale-version branch January 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants