Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codeowners #1388

Merged
merged 2 commits into from
Jan 10, 2024
Merged

chore: add codeowners #1388

merged 2 commits into from
Jan 10, 2024

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Jan 10, 2024

What/Why/How?

Currently, we review the changelog before the release, and if it needs to be corrected, we open yet another technical MR to fix the changesets. It's inconvenient and adds extra commits to the history.

Added @Redocly/technical-writers as the code owners of the .changeset/ folder to get future changelog entries reviewed earlier.

Also, added the docs/ folder under tech writers' ownership.

Also, updated the contributing guide.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested a review from a team as a code owner January 10, 2024 11:48
@tatomyr tatomyr self-assigned this Jan 10, 2024
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 16d4e2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.059 ± 0.025 1.018 1.112 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.066 ± 0.021 1.034 1.095 1.01 ± 0.03

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.31% 4100/5373
🟡 Branches 66.29% 2183/3293
🟡 Functions 68.42% 663/969
🟡 Lines 76.51% 3847/5028

Test suite run success

671 tests passing in 94 suites.

Report generated by 🧪jest coverage report action from 16d4e2d

@tatomyr tatomyr requested a review from lornajane January 10, 2024 12:08
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, thanks!

@lornajane
Copy link
Contributor

There is a fix for the failing documentation tests build task in #1387

@tatomyr tatomyr force-pushed the chore/add-code-owners branch from 074ed62 to 16d4e2d Compare January 10, 2024 12:50
@tatomyr tatomyr merged commit 6bcf554 into main Jan 10, 2024
29 checks passed
@tatomyr tatomyr deleted the chore/add-code-owners branch January 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants