Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): Align selectors, functions with PF5 #1968

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Feb 8, 2024

This makes the cypress utilities consistent with the PF5 upgrades. Mainly selectors are affected, but so do the helping functions that use them.

@gkarat gkarat added the utils update to utils package label Feb 8, 2024
@gkarat gkarat requested review from Hyperkid123 and a team February 8, 2024 15:56
@gkarat gkarat self-assigned this Feb 8, 2024
This makes the cypress utilities consistent with the PF5 upgrades. Mainly selectors are affected, but so do the helping functions that use them.
Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Great job!

@gkarat gkarat merged commit 284fce1 into RedHatInsights:master Feb 9, 2024
1 check passed
@gkarat gkarat deleted the update-cypress-utils branch February 9, 2024 14:19
@gkarat
Copy link
Contributor Author

gkarat commented Feb 9, 2024

Hmm, the automation doesn't upgrade the package for some reason

@gkarat
Copy link
Contributor Author

gkarat commented Feb 9, 2024

@RedHatInsights/platform-experience ^

@karelhala karelhala added the release Once merged it will trigger bugfix release label Feb 9, 2024
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-utilities/v/4.0.4📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Once merged it will trigger bugfix release released Pr has been released utils update to utils package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants