test(RHINENG-8182): Update cypress tests after PF5 upgrade #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
added
dependencies
gkarat
added a commit
to gkarat/insights-inventory-frontend
that referenced
this pull request
Feb 9, 2024
This is trade-off to not to block the upgrade of PF. Will be enabled back in RedHatInsights#2146.
gkarat
added a commit
to gkarat/insights-inventory-frontend
that referenced
this pull request
Feb 9, 2024
This is trade-off to not to block the upgrade of PF. Will be enabled back in RedHatInsights#2146.
gkarat
changed the title
gkarat
force-pushed
the
rhineng-3032-cypress
branch
from
fedbb03 to
296e88e
Compare
gkarat
force-pushed
the
rhineng-3032-cypress
branch
from
296e88e to
d26d4be
Compare
|
/retest |
gkarat
added a commit
that referenced
this pull request
Feb 20, 2024
…#2141) * chore: Upgrade React and PF with other affected packages * chore: Running pf-codemods fix * chore: Wrap icons * chore(TopBar): Rewrite Dropdown * chore: Install jest-environment-jsdom * chore: Add missing conditional filter type * chore: Update SkeletonTable columns prop * chore: Fix the jest warning regarding testUrl * chore: Fix "import statement" issue with Jest * chore(GroupDetailHeader): Rebuild Dropdown * chore: Run classnames fix * chore: Update test snapshots * chore: Update hook tests * chore: Update SkeletonTable props * chore: Fix the rest of unit tests after migration * chore: Use cypress/react18, tweak toggle text selectors * chore(InventoryTable): Provide count to PrimaryToolbar * chore: Temporarily disable cypress tests in Travis CI This is trade-off to not to block the upgrade of PF. Will be enabled back in #2146. * chore(ActionDropdownItem): Fix and preserve dropdown style * chore(SearchableGroupFilter): Keep checkboxes and styling
gkarat
force-pushed
the
rhineng-3032-cypress
branch
from
e1a59cc to
0258141
Compare
gkarat
force-pushed
the
rhineng-3032-cypress
branch
from
0258141 to
2eb9ad0
Compare
gkarat
force-pushed
the
rhineng-3032-cypress
branch
from
2eb9ad0 to
c72bc81
Compare
|
/retest |
|
@computercamplove, by any chance, is there something in e2e tests that caused by this PR? |
mkholjuraev
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
@gkarat thank you, I could not spot anything to suggest. All looks great!
no, 1 test is failed that i created for PR for @bastilian, i am going to disable it, looks like this PR is still in progress. Thank you for reminder, you can ignore it |
|
🎉 This PR is included in version 1.67.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/RHINENG-8182.
Follows up on: #2141
Blocked by RedHatInsights/frontend-components#1968
This enables back the cypress test in Travis CI and makes them pass by updating selectors after PF5 migration.