feat: add performance budget review for Aegis Dashboard (#44) - #185
Merged
El-swaggerito merged 1 commit intoJul 29, 2026
Merged
Conversation
- Add typed performance budget review data model in src/lib/performanceBudget.ts - BudgetCheck, BudgetReviewResult, BudgetReviewState types - deriveBudgetStatus, filterBudgetResults, tallyBudgetResults pure functions - Bulk actions: approve, reject, flag-for-review, clear - validateBudgetChecks for internal consistency validation - budgetResultLabel with compliance-safe disclaimer integration - Add unit tests in src/lib/performanceBudget.test.ts (30 tests) - Status derivation for all four outcomes - Custom rule override, severity ranking, filtering, tally - Selection helpers, bulk actions, value formatting - Fixture sanity checks - Add fixtures in src/lib/__fixtures__/performanceBudget.ts - 4-row sample queue exercising all statuses and check results - Add PerformanceBudgetPanel component in src/features/diagnostics/components/ - Reusable table with filtering, sorting, saved views - Bulk action bar with confirmation flow - COMPLIANCE_DISCLAIMER on header and action confirmations - Empty state with docs link - Extend SDK provider interface (IAegisProvider) with getPerformanceBudget - Implemented in MockAegisProvider and LiveAegisProvider - Mock client in src/lib/aegis/client.ts - Add performanceBudgetReview feature flag in useFeatureFlags - Add docs/performance-budget-review.md with full contributor guidance - Data model, behaviour, edge cases, security assumptions - Tests, fixtures, and reviewer checklist - Compliance-safe wording guidance - Update README.md and docs/README.md with links to new documentation - All 455 tests pass, build succeeds, no lint errors
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the performance budget review feature for the Aegis Dashboard (Issue #44).
Changes
Core Logic
BudgetCheck,BudgetReviewResult,BudgetReviewStatetypesderiveBudgetStatus— maps check results tocompliant | warning | breached | unknownfilterBudgetResults,tallyBudgetResults,validateBudgetChecksapprove | reject | flag-for-review | clearbudgetResultLabelwith compliance-safe disclaimer integrationTests
Fixtures
UI Component
SDK Integration
IAegisProviderwithgetPerformanceBudgetmethodMockAegisProviderandLiveAegisProvidersrc/lib/aegis/client.tsFeature Flag
performanceBudgetReviewflag inuseFeatureFlagsDocumentation
Acceptance Criteria
Verification
Closes #44