Skip to content

fix(api): gracefully handle unsupported ScAddress variants (#89) #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valoryyaa-byte merged 2 commits into from
Jul 28, 2026
Merged

fix(api): gracefully handle unsupported ScAddress variants (#89) #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54248b
fix(api): gracefully handle unsupported ScAddress variants (#89)
wendyamoni-creator Jul 27, 2026
2172774
Merge branch 'main' into fix/issue-89-address-decode-fallback
wendyamoni-creator Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/src/indexer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,14 @@ fn address_to_string(a: &xdr::ScAddress) -> Result<String, IndexError> {
xdr::ScAddress::Contract(xdr::ContractId(xdr::Hash(bytes))) => {
Ok(stellar_strkey::Contract(*bytes).to_string())
}
// Muxed accounts and any future address variants are not expected from
// these contracts, but returning an error here would abort the entire
// refresh cycle via `?`. Emit a recognisable placeholder so callers
// can still process the rest of the response.
other => {
tracing::warn!("address_to_string: unsupported address variant, using placeholder: {other:?}");
Ok(format!("unknown:{other:?}"))
}
other => Err(IndexError::Unsupported(format!(
"unsupported address: {other:?}"
))),
Expand Down
Loading