fix(api): gracefully handle unsupported ScAddress variants (#89) - #155
Merged
valoryyaa-byte merged 2 commits intoJul 28, 2026
Conversation
…it#89) address_to_string previously returned an Err for any address variant other than Ed25519 Account or Contract, which would propagate via ? through scval_to_json and abort the entire refresh cycle. Replace the error arm with a warn! log + an 'unknown:<debug>' placeholder string so the decode succeeds and the indexer cycle continues normally. Fixes RWA-ToolKit#89
|
@wendyamoni-creator Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #89.
address_to_stringinapi/src/indexer/mod.rsonly handled twoScAddressvariants —Account(Ed25519)andContract. Any other variant (e.g. muxed accounts) returnedErr(IndexError::Decode(...)), which propagated via?inscval_to_jsonand could abort the entire 10-second refresh cycle.Change
Replace the error arm with a graceful fallback:
tracing::warn!so the anomaly is visible without being fatal.Ok("unknown:<debug repr>")so the decode succeeds and the indexer cycle continues normally.No call-site changes needed — the function signature is unchanged.
Files changed
api/src/indexer/mod.rs—address_to_stringfallback arm closes api: address decode only supports ed25519 accounts and contracts — muxed/other address types error out #89