Repository navigation
[rocjitsu] Regenerate matrix conversion header during DBT codegen - #13050
Merged
Merged
Conversation
github-actions
Bot
added
documentation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
force-pushed
the
users/newling/fix-rocjitsu-matrix-regeneration
branch
from
October 13, 2026 21:18
7094409 to
d8805c0
Compare
newling
marked this pull request as ready for review
October 13, 2026 21:19
kuhar
reviewed
Oct 13, 2026
kuhar
left a comment
kuhar
left a comment
Member
There was a problem hiding this comment.
It would help to tidy two misleading parts of the emitter's interface and attribution while wiring it into the CLI:
emulation/rocjitsu/lib/python/amdisa/codegen/dbt/rule_gen.py:316: remove the unusedguardparameter. Passing a custom value has no effect because the emitter always uses#pragma once, and no in-tree caller supplies it.emulation/rocjitsu/lib/python/amdisa/codegen/dbt/rule_gen.py:325: update the generated banner to namerule_gen.pyor the amdisa codegen pipeline. It currently points maintainers tolayout_catalog, which derives layouts but does not emit the header.
These are small clarity improvements; neither changes the generated table values.
kuhar
reviewed
Oct 14, 2026
newling
force-pushed
the
users/newling/fix-rocjitsu-matrix-regeneration
branch
from
October 15, 2026 17:21
d8805c0 to
164ddf1
Compare
kuhar
approved these changes
Oct 16, 2026
newling
force-pushed
the
users/newling/fix-rocjitsu-matrix-regeneration
branch
4 times, most recently
from
October 18, 2026 17:24
3447f1f to
42d3f2e
Compare
newling
force-pushed
the
users/newling/fix-rocjitsu-matrix-regeneration
branch
from
October 18, 2026 17:54
42d3f2e to
d7f567c
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matrix_conversions.hsupplies the lane-permutation data used when translating CDNA4 MFMA instructions to RDNA4 WMMA instructions. A report thatemulation/rocjitsu/scripts/generate-amdisa.shcould not recreate this header exposed a missing generation step: the Python layout derivation and header emitter existed, butpython -m amdisanever called them. DBT generation therefore succeeded while leaving a missing header absent or an existing header untouched, even if its contents were stale. The checked-in copy hid this defect in populated checkouts. The header and emitter were introduced in #5942.Call the existing derivation and emitter during DBT generation so both
--dbt-outputand the--isa-outputfallback recreate the header. An explicit inventory preserves the four existing source/target pairs and every table value; these pairs describe lane layouts, and adding one does not establish instruction availability or implement a new translation. Document the inventory and layout formulas, and update the CLI help to describe the additional output. Also emit<cstddef>and usestd::size_t, fixing the header's failure to compile without preceding includes.CLI regressions cover missing and stale headers with each output option and compare the complete regenerated catalog against the tracked header. The focused generator, rule and layout tests pass on the rebased branch, as do standalone C++20 compilation with assertions for all four original entries and changed-file pre-commit hooks. Two existing tests skip because optional semantics XML is unavailable.