Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for gfx940, gfx941 #900

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −29
Open

Remove support for gfx940, gfx941 #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions library/src/specialized/roclapack_trsm_specialized_kernels.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* **************************************************************************
* Copyright (C) 2019-2024 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (C) 2019-2025 Advanced Micro Devices, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -866,8 +866,6 @@ rocblas_status rocsolver_trsm_lower(rocblas_handle handle,
HIP_CHECK(hipGetDeviceProperties(&deviceProperties, device));
std::string deviceFullString(deviceProperties.gcnArchName);
std::string deviceString = deviceFullString.substr(0, deviceFullString.find(":"));
Comment on lines 866 to 868
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can remove all of this as well (and the 4 lines above), since it was only needed for the switch

bool do_sync = (deviceString.find("gfx940") != std::string::npos
|| deviceString.find("gfx941") != std::string::npos);

// ****** MAIN LOOP ***********
if(isleft)
Expand Down Expand Up @@ -898,9 +896,6 @@ rocblas_status rocsolver_trsm_lower(rocblas_handle handle,
offB = idx2D(j, 0, incb, ldb);
FORWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update right hand sides
ROCBLAS_CHECK(rocsolver_gemm(handle, rocblas_operation_none, rocblas_operation_none,
m - nextpiv, n, blk, &minone, A,
Expand Down Expand Up @@ -942,9 +937,6 @@ rocblas_status rocsolver_trsm_lower(rocblas_handle handle,
offB = idx2D(m - nextpiv, 0, incb, ldb);
BACKWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update right hand sides
ROCBLAS_CHECK(rocsolver_gemm(
handle, trans, rocblas_operation_none, m - nextpiv, n, blk, &minone, A,
Expand Down Expand Up @@ -998,9 +990,6 @@ rocblas_status rocsolver_trsm_lower(rocblas_handle handle,
offB = idx2D(0, n - nextpiv, incb, ldb);
BACKWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update left hand sides
ROCBLAS_CHECK(rocsolver_gemm(
handle, rocblas_operation_none, rocblas_operation_none, m, n - nextpiv, blk,
Expand Down Expand Up @@ -1041,9 +1030,6 @@ rocblas_status rocsolver_trsm_lower(rocblas_handle handle,
offB = idx2D(0, j, incb, ldb);
FORWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update left hand sides
ROCBLAS_CHECK(rocsolver_gemm(handle, rocblas_operation_none, trans, m, n - nextpiv,
blk, &minone, B, shiftB + idx2D(0, j, incb, ldb), incb,
Expand Down Expand Up @@ -1151,8 +1137,6 @@ rocblas_status rocsolver_trsm_upper(rocblas_handle handle,
HIP_CHECK(hipGetDeviceProperties(&deviceProperties, device));
std::string deviceFullString(deviceProperties.gcnArchName);
std::string deviceString = deviceFullString.substr(0, deviceFullString.find(":"));
Comment on lines 1137 to 1139
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

bool do_sync = (deviceString.find("gfx940") != std::string::npos
|| deviceString.find("gfx941") != std::string::npos);

// ****** MAIN LOOP ***********
if(isleft)
Expand Down Expand Up @@ -1183,9 +1167,6 @@ rocblas_status rocsolver_trsm_upper(rocblas_handle handle,
offB = idx2D(j, 0, incb, ldb);
FORWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update right hand sides
ROCBLAS_CHECK(rocsolver_gemm(handle, trans, rocblas_operation_none, m - nextpiv, n,
blk, &minone, A, shiftA + idx2D(j, nextpiv, inca, lda),
Expand Down Expand Up @@ -1227,9 +1208,6 @@ rocblas_status rocsolver_trsm_upper(rocblas_handle handle,
offB = idx2D(m - nextpiv, 0, incb, ldb);
BACKWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update right hand sides
ROCBLAS_CHECK(rocsolver_gemm(
handle, rocblas_operation_none, rocblas_operation_none, m - nextpiv, n, blk,
Expand Down Expand Up @@ -1283,9 +1261,6 @@ rocblas_status rocsolver_trsm_upper(rocblas_handle handle,
offB = idx2D(0, n - nextpiv, incb, ldb);
BACKWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update left hand sides
ROCBLAS_CHECK(rocsolver_gemm(
handle, rocblas_operation_none, trans, m, n - nextpiv, blk, &minone, B,
Expand Down Expand Up @@ -1326,9 +1301,6 @@ rocblas_status rocsolver_trsm_upper(rocblas_handle handle,
offB = idx2D(0, j, incb, ldb);
FORWARD_SUBSTITUTIONS;

if(do_sync)
HIP_CHECK(hipStreamSynchronize(stream));

// update left hand sides
ROCBLAS_CHECK(rocsolver_gemm(handle, rocblas_operation_none, rocblas_operation_none,
m, n - nextpiv, blk, &minone, B,
Expand Down
Loading