Remove support for gfx940, gfx941 #900
Open
+1
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjojo
requested review from
jzuniga-amd,
tfalders,
cgmb,
EdDAzevedo,
jmachado-amd and
AGonzales-amd
as code owners
tfalders
reviewed
Feb 26, 2025
Comment on lines
866
to
868
| HIP_CHECK(hipGetDeviceProperties(&deviceProperties, device)); | ||
| std::string deviceFullString(deviceProperties.gcnArchName); | ||
| std::string deviceString = deviceFullString.substr(0, deviceFullString.find(":")); |
There was a problem hiding this comment.
I believe you can remove all of this as well (and the 4 lines above), since it was only needed for the switch
Comment on lines
1137
to
1139
| HIP_CHECK(hipGetDeviceProperties(&deviceProperties, device)); | ||
| std::string deviceFullString(deviceProperties.gcnArchName); | ||
| std::string deviceString = deviceFullString.substr(0, deviceFullString.find(":")); |
tfalders
added
the
noOptimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a switch needed for gfx940 and gfx941 as ROCm does not support those targets anymore.