Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Unit tests for tunable ConvHipImplicitGemm* solvers #3643

Open
wants to merge 56 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
4bbeb31
Add unit test for ConvHipImplicitGemmBwdDataV1R1, remove old test
averinevg Mar 18, 2025
c961775
Fix formatting
averinevg Mar 18, 2025
2db4f2d
Add unit test for ConvHipImplicitGemmBwdDataV1R1Xdlops, remove old tests
averinevg Mar 18, 2025
a382050
Fix formatting
averinevg Mar 18, 2025
0182b25
Add unit test for ConvHipImplicitGemmBwdDataV4R1, remove old tests
averinevg Mar 18, 2025
8b9a1b8
Fix formatting
averinevg Mar 18, 2025
29a9bd4
Add unit test for ConvHipImplicitGemmBwdDataV4R1Xdlops, remove old tests
averinevg Mar 18, 2025
fb8985a
Fix bug in unit_conv_solver.cpp, add regression test for solver
averinevg Mar 18, 2025
979f552
Fix test cases
averinevg Mar 19, 2025
ea5ac6a
Add unit test for ConvHipImplicitGemmV4R1Fwd, remove old tests
averinevg Mar 19, 2025
2c278df
Fix formatting
averinevg Mar 19, 2025
20febed
Add unit test for ConvHipImplicitGemmV4R1WrW, remove old test
averinevg Mar 19, 2025
d8acf28
Add unit test for ConvHipImplicitGemmV4R4Fwd, remove old test
averinevg Mar 19, 2025
6a61dd7
Fix formatting
averinevg Mar 19, 2025
1ee2d3d
Add unit test for ConvHipImplicitGemmV4R4WrW, remove old test
averinevg Mar 19, 2025
9267ee7
Add unit test for ConvHipImplicitGemmForwardV4R4Xdlops, remove old tests
averinevg Mar 19, 2025
ee89221
Fix params.Tunable()
averinevg Mar 19, 2025
70ba84c
Fix formatting
averinevg Mar 19, 2025
6034be8
Add unit test for ConvHipImplicitGemmForwardV4R4Xdlops_Padded_Gemm, r…
averinevg Mar 19, 2025
75896aa
Fix formatting
averinevg Mar 19, 2025
59e6cec
Add unit test for ConvHipImplicitGemmForwardV4R5Xdlops, remove old test
averinevg Mar 19, 2025
577ea7c
Fix formatting
averinevg Mar 19, 2025
3720dfb
Add unit test for ConvHipImplicitGemmWrwV4R4Xdlops, remove old test
averinevg Mar 19, 2025
6c29948
Fix formatting
averinevg Mar 19, 2025
b7f54c1
Add unit test for ConvHipImplicitGemmWrwV4R4Xdlops_Padded_Gemm, remov…
averinevg Mar 19, 2025
72d0e0b
Fix formatting
averinevg Mar 19, 2025
56fe4e9
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 19, 2025
e908a2f
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 20, 2025
c59f891
UnitTestConvSolverParams: add tolerances
averinevg Mar 20, 2025
81252d1
Fix formatting
averinevg Mar 20, 2025
da66fa5
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 20, 2025
652e93c
Fix tolerance for ConvHipImplicitGemmV4R4WrW and ConvOclBwdWrW2
averinevg Mar 20, 2025
7e25d9d
Fix tolerance for ConvHipImplicitGemmV4R1WrW and ConvHipImplicitGemmW…
averinevg Mar 21, 2025
47e668a
Fix tolerance for ConvHipImplicitGemmV4R1WrW
averinevg Mar 21, 2025
f3b312e
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 24, 2025
8938345
Fix tolerances
averinevg Mar 24, 2025
f3d77a9
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 25, 2025
21fb849
Fix tolerances, add temporary tests for ConvHipImplicitGemmV4R1Fwd
averinevg Mar 25, 2025
f0871fa
Fix formatting
averinevg Mar 25, 2025
e9b08ca
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 26, 2025
e6505fe
Fix tolerance for ConvHipImplicitGemmV4R1Fwd
averinevg Mar 26, 2025
e6b6ac0
Extend logging
averinevg Mar 26, 2025
11309fc
Fix formatting
averinevg Mar 26, 2025
899a1f4
Fix tolerance for ConvHipImplicitGemmV4R1Fwd, remove temporary tests
averinevg Mar 26, 2025
cce4985
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 27, 2025
71780e7
Fix tolerances for ConvAsmImplicitGemmGTCDynamicBwdXdlopsNHWC and Con…
averinevg Mar 27, 2025
4481c1c
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 28, 2025
a2dde88
Fix tolerances for ConvAsmImplicitGemmGTCDynamicFwdXdlopsNHWC, ConvAs…
averinevg Mar 28, 2025
4a1958b
Test on MI100
averinevg Mar 28, 2025
d59ba14
Fix tolerances for gfx908
averinevg Mar 28, 2025
3afcace
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Mar 28, 2025
64e9c5d
Fix tolerances for ConvAsmImplicitGemmGTCDynamic*
averinevg Mar 31, 2025
ee57d4c
Revert "Test on MI100"
averinevg Mar 31, 2025
7d17ff6
Cleanup
averinevg Mar 31, 2025
081fb49
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
averinevg Apr 1, 2025
9a0978b
Fix tolerance for ConvAsmImplicitGemmGTCDynamicWrwXdlopsNHWC
averinevg Apr 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/env_debug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_GEMM)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V1R1_XDLOPS)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_FWD_V4R1)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1_XDLOPS)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_CONV_WINOGRAD)
MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_ENABLE_DEPRECATED_SOLVERS)
Expand Down Expand Up @@ -185,7 +184,6 @@ const LibEnvVar& FindEnvVariable(std::string_view name)
{MIOPEN_DEBUG_CONV_IMPLICIT_GEMM.GetName(), MIOPEN_DEBUG_CONV_IMPLICIT_GEMM},
{MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1.GetName(), MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1},
{MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V1R1_XDLOPS.GetName(), MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V1R1_XDLOPS},
{MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_FWD_V4R1.GetName(), MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_FWD_V4R1},
{MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1_XDLOPS.GetName(), MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1_XDLOPS},
{MIOPEN_DEBUG_CONV_WINOGRAD.GetName(), MIOPEN_DEBUG_CONV_WINOGRAD},
{MIOPEN_DEBUG_CONVOLUTION_ATTRIB_FP16_ALT_IMPL.GetName(), MIOPEN_DEBUG_CONVOLUTION_ATTRIB_FP16_ALT_IMPL},
Expand Down
15 changes: 0 additions & 15 deletions test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -710,21 +710,6 @@ set(IMPLICITGEMM_TESTING_ENV
MIOPEN_DEBUG_CONV_IMPLICIT_GEMM=1
)

if(WORKAROUND_ISSUE_936 AND MIOPEN_TEST_HALF)
SET(SAVE_IMPLICITGEMM_TESTING_ENV ${IMPLICITGEMM_TESTING_ENV})
LIST(APPEND IMPLICITGEMM_TESTING_ENV MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_FWD_V4R1=0 MIOPEN_FIND_MODE=normal)
SET(SAVE_MIOPEN_TEST_FLOAT_ARG ${MIOPEN_TEST_FLOAT_ARG})
LIST(APPEND MIOPEN_TEST_FLOAT_ARG --disable-forward --disable-backward-data)
#Afther fix need to remove '| grep -v "No suitable algorithm was found to execute the required convolution"'
endif()



if(WORKAROUND_ISSUE_936 AND MIOPEN_TEST_HALF)
SET(IMPLICITGEMM_TESTING_ENV ${SAVE_IMPLICITGEMM_TESTING_ENV})
SET(MIOPEN_TEST_FLOAT_ARG ${SAVE_MIOPEN_TEST_FLOAT_ARG})
endif()

if(MIOPEN_TEST_DEEPBENCH)
add_custom_test(test_deepbench_rnn GFX94X_ENABLED GFX103X_ENABLED GFX110X_ENABLED
)
Expand Down
4 changes: 0 additions & 4 deletions test/gtest/gtest_common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -287,10 +287,6 @@ MIOPEN_LIB_ENV_VAR(MIOPEN_DEBUG_CONV_GEMM)
MIOPEN_LIB_ENV_VAR(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM)
MIOPEN_LIB_ENV_VAR(MIOPEN_LOG_LEVEL)
MIOPEN_LIB_ENV_VAR(MIOPEN_FIND_ENFORCE)
MIOPEN_LIB_ENV_VAR(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V1R1_XDLOPS)
MIOPEN_LIB_ENV_VAR(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1)
MIOPEN_LIB_ENV_VAR(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_FWD_V4R1)
MIOPEN_LIB_ENV_VAR(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V4R1_XDLOPS)

/// \todo Remove workarounds
namespace wa {
Expand Down
82 changes: 0 additions & 82 deletions test/gtest/regression_half_mi100.cpp

This file was deleted.

100 changes: 0 additions & 100 deletions test/gtest/regression_half_mi200.cpp

This file was deleted.

84 changes: 0 additions & 84 deletions test/gtest/smoke_solver_ConvHipImplicitGemmBwdDataV1R1.cpp

This file was deleted.

Loading
Loading