Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Unit tests for tunable ConvHipImplicitGemm* solvers #3643

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from
Open

[tests] Unit tests for tunable ConvHipImplicitGemm* solvers #3643

wants to merge 51 commits into from
+1,847 −1,076

Conversation

averinevg
Copy link
Contributor

@averinevg averinevg commented Mar 19, 2025 •
edited
Loading

This PR adds unit tests for implicit gemm solvers from #3624:

  • ConvHipImplicitGemmBwdDataV1R1
  • ConvHipImplicitGemmBwdDataV1R1Xdlops
  • ConvHipImplicitGemmBwdDataV4R1
  • ConvHipImplicitGemmBwdDataV4R1Xdlops
  • ConvHipImplicitGemmForwardV4R4Xdlops
  • ConvHipImplicitGemmForwardV4R4Xdlops_Padded_Gemm
  • ConvHipImplicitGemmForwardV4R5Xdlops
  • ConvHipImplicitGemmV4R1Fwd
  • ConvHipImplicitGemmV4R1WrW
  • ConvHipImplicitGemmV4R4Fwd
  • ConvHipImplicitGemmV4R4WrW
  • ConvHipImplicitGemmWrwV4R4Xdlops
  • ConvHipImplicitGemmWrwV4R4Xdlops_Padded_Gemm

Additional changes:

  • Tolerances can be set separately for each solver
  • Tuning parameters for existing unit tests have been fixed
  • Fixed bug in unit_conv_solver.cpp (the descriptors were mixed up, only the applicability tests were affected)
  • Some cleanup
  • Old tests have been removed

averinevg added 26 commits March 18, 2025 19:59
@averinevg
Add unit test for ConvHipImplicitGemmBwdDataV1R1, remove old test
4bbeb31
@averinevg
Fix formatting
c961775
@averinevg
Add unit test for ConvHipImplicitGemmBwdDataV1R1Xdlops, remove old tests
2db4f2d
@averinevg
Fix formatting
a382050
@averinevg
Add unit test for ConvHipImplicitGemmBwdDataV4R1, remove old tests
0182b25
@averinevg
Fix formatting
8b9a1b8
@averinevg
Add unit test for ConvHipImplicitGemmBwdDataV4R1Xdlops, remove old tests
29a9bd4
@averinevg
Fix bug in unit_conv_solver.cpp, add regression test for solver
fb8985a
@averinevg
Fix test cases
979f552
@averinevg
Add unit test for ConvHipImplicitGemmV4R1Fwd, remove old tests
ea5ac6a
@averinevg
Fix formatting
2c278df
@averinevg
Add unit test for ConvHipImplicitGemmV4R1WrW, remove old test
20febed
@averinevg
Add unit test for ConvHipImplicitGemmV4R4Fwd, remove old test
d8acf28
@averinevg
Fix formatting
6a61dd7
@averinevg
Add unit test for ConvHipImplicitGemmV4R4WrW, remove old test
1ee2d3d
@averinevg
Add unit test for ConvHipImplicitGemmForwardV4R4Xdlops, remove old tests
9267ee7
@averinevg
Fix params.Tunable()
ee89221
@averinevg
Fix formatting
70ba84c
@averinevg
Add unit test for ConvHipImplicitGemmForwardV4R4Xdlops_Padded_Gemm, r…
6034be8 
…emove old test
@averinevg
Fix formatting
75896aa
@averinevg
Add unit test for ConvHipImplicitGemmForwardV4R5Xdlops, remove old test
59e6cec
@averinevg
Fix formatting
577ea7c
@averinevg
Add unit test for ConvHipImplicitGemmWrwV4R4Xdlops, remove old test
3720dfb
@averinevg
Fix formatting
6c29948
@averinevg
Add unit test for ConvHipImplicitGemmWrwV4R4Xdlops_Padded_Gemm, remov…
b7f54c1 
…e old test
@averinevg
Fix formatting
Loading
Loading status checks…
72d0e0b
@averinevg averinevg requested review from shurale-nkn and scerzh March 19, 2025 21:03
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
56fe4e9
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
e908a2f
@averinevg
UnitTestConvSolverParams: add tolerances
c59f891
@averinevg
Fix formatting
Loading
Loading status checks…
81252d1
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
da66fa5
@averinevg
Fix tolerance for ConvHipImplicitGemmV4R4WrW and ConvOclBwdWrW2
Loading
Loading status checks…
652e93c
@averinevg
Fix tolerance for ConvHipImplicitGemmV4R1WrW and ConvHipImplicitGemmW…
Loading
Loading status checks…
7e25d9d 
…rwV4R4Xdlops_Padded_Gemm
@averinevg
Fix tolerance for ConvHipImplicitGemmV4R1WrW
Loading
Loading status checks…
47e668a
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
f3b312e
@scerzh scerzh self-requested a review March 26, 2025 13:00
averinevg added 10 commits March 26, 2025 14:43
@averinevg
Extend logging
e6b6ac0
@averinevg
Fix formatting
Loading
Loading status checks…
11309fc
@averinevg
Fix tolerance for ConvHipImplicitGemmV4R1Fwd, remove temporary tests
Loading
Loading status checks…
899a1f4
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
cce4985
@averinevg
Fix tolerances for ConvAsmImplicitGemmGTCDynamicBwdXdlopsNHWC and Con…
Loading
Loading status checks…
71780e7 
…vAsmImplicitGemmGTCDynamicWrwXdlopsNHWC
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
4481c1c
@averinevg
Fix tolerances for ConvAsmImplicitGemmGTCDynamicFwdXdlopsNHWC, ConvAs…
Loading
Loading status checks…
a2dde88 
…mImplicitGemmGTCDynamicBwdXdlopsNHWC and ConvAsmImplicitGemmGTCDynamicWrwXdlopsNHWC
@averinevg
Test on MI100
Loading
Loading status checks…
4a1958b
@averinevg
Fix tolerances for gfx908
d59ba14
@averinevg
Merge branch 'develop' into ea_unit_tests_for_solvers_from_pr_3624
Loading
Loading status checks…
3afcace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shurale-nkn shurale-nkn

@BrianHarrisonAMD BrianHarrisonAMD

@BradPepersAMD BradPepersAMD

@adickin-amd adickin-amd

@JonathanLichtnerAMD JonathanLichtnerAMD

@scerzh scerzh

Assignees
No one assigned
Labels
GTest quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@averinevg @scerzh