Skip to content

[AIMIGRAPHX-364] Upgrade ASAN and libstdc++ tests to Clang 17 #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

[AIMIGRAPHX-364] Upgrade ASAN and libstdc++ tests to Clang 17 #4466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
67d44ef
Move stage wrapper, add check before parallel
eddieliao Nov 5, 2025
ad4a315
Declarative refactor, per stage reporting with gitStatusWrapper
eddieliao Nov 12, 2025
578b74a
Add Jenkins prefix gitHubContext
eddieliao Nov 13, 2025
be11ab0
Wrap ORT tests in parallel stage
eddieliao Nov 13, 2025
0c8126b
Add asan-globals=0 to disable global variable checks
eddieliao Nov 14, 2025
a0e83de
Move checkout before unstash
eddieliao Nov 17, 2025
f841cc7
Merge branch 'ci_incorrect_time' into clang_asan_failure
eddieliao Nov 18, 2025
6f2cd4b
Merge branch 'develop' into clang_asan_failure
eddieliao Nov 21, 2025
0c924a7
Upgrade ASAN and libstdc++ tests to Clang 17
eddieliao Nov 25, 2025
f7dbf76
Use curl instead of wget
eddieliao Nov 25, 2025
ba72b9a
Use LLVM apt repository and add libomp-17 dependency
eddieliao Nov 25, 2025
0b6d674
Use only one version of OpenMP
eddieliao Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,16 @@ RUN sh -c "echo 'Package: *\nPin: release o=repo.radeon.com\nPin-priority: 600'
# rocgdb doesn't work on 22.04, workaround by installing the older python packages that are in 20.04
RUN add-apt-repository -y ppa:deadsnakes/ppa

# Add LLVM repository for Clang 17 (ROCm 7.x ships with Clang 20 which has ODR false positives in ASAN)
RUN curl -sL https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - && \
add-apt-repository -y "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main"

# Install dependencies
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --allow-unauthenticated \
apt-utils \
bison \
build-essential \
clang-14 \
clang-17 \
cmake \
curl \
flex \
Expand All @@ -43,7 +47,7 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --allow-
hip-dev \
libnuma-dev \
miopen-hip \
libomp-dev \
libomp-17-dev \
rocblas \
hipfft \
hipsolver \
Expand Down
4 changes: 2 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ pipeline {
def debug_flags = "-g -O2 -fno-omit-frame-pointer -fsanitize=${sanitizers} -fno-sanitize-recover=${sanitizers}"
buildrocmtest(
[flags: "-DCMAKE_BUILD_TYPE=debug -DMIGRAPHX_ENABLE_C_API_TEST=Off -DMIGRAPHX_ENABLE_PYTHON=Off -DMIGRAPHX_ENABLE_GPU=Off -DMIGRAPHX_ENABLE_CPU=On -DCMAKE_CXX_FLAGS_DEBUG='${debug_flags}'",
compiler: '/usr/bin/clang++-14',
compiler: '/usr/bin/clang++-17',
gpu_debug: '0'],
docker_opts
)
Expand All @@ -276,7 +276,7 @@ pipeline {
def debug_flags = "-g -O2 -fno-omit-frame-pointer -fsanitize=${sanitizers} -fno-sanitize-recover=${sanitizers} -D_GLIBCXX_DEBUG"
buildrocmtest(
[flags: "-DCMAKE_BUILD_TYPE=debug -DMIGRAPHX_ENABLE_C_API_TEST=Off -DMIGRAPHX_ENABLE_PYTHON=Off -DMIGRAPHX_ENABLE_GPU=Off -DMIGRAPHX_ENABLE_CPU=Off -DCMAKE_CXX_FLAGS_DEBUG='${debug_flags}'",
compiler: '/usr/bin/clang++-14',
compiler: '/usr/bin/clang++-17',
gpu_debug: '0'],
docker_opts
)
Expand Down
Loading