[AIMIGRAPHX-364] Upgrade ASAN and libstdc++ tests to Clang 17 #4466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Clang version from 14 to 17 for ASAN (AddressSanitizer) and libstdc++ debug tests to resolve intermittent segfault issues that have been fixed in Clang 17. The change avoids Clang 20 (shipped with ROCm 7.0) due to ODR (One Definition Rule) violation false positives that cannot be easily disabled.
Key Changes:
- Updated compiler paths from
/usr/bin/clang++-14to/usr/bin/clang++-17in CI/CD pipeline - Modified Dockerfile to install Clang 17 using the official LLVM installation script
- Removed the
clang-14package from the dependency list
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Jenkinsfile | Updated compiler paths to clang++-17 for both the "Clang ASAN" and "Clang libstdc++ Debug" test stages |
| Dockerfile | Added Clang 17 installation via llvm.sh script and removed clang-14 from the apt package list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfultz2
reviewed
Nov 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4466 +/- ##
========================================
Coverage 92.21% 92.21%
========================================
Files 561 561
Lines 27218 27228 +10
========================================
+ Hits 25097 25107 +10
Misses 2121 2121 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clang ASAN tests currently fail intermittently due to a segfault issue that has been fixed in Clang 17 and onward.
Technical Details
Upgrades to Clang 17. Clang 20 that comes with ROCm 7.0 cannot be used for ASAN tests as it results in tests failing due to an ODR violation. There did not appear to be a way to properly disable the check without disabling all global variable checking through ASAN.
Changelog Category