-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove errant print
statements from tests
#13702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any `print` is necessary for debugging failed test cases, we probably ought to reconfigure the test runner's display mechanisms, or use the built-in configuration of the `unittest` assert methods to produce better results.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 12887902365Details
💛 - Coveralls |
ElePT
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. Probably would be good to backport too?
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
If any `print` is necessary for debugging failed test cases, we probably ought to reconfigure the test runner's display mechanisms, or use the built-in configuration of the `unittest` assert methods to produce better results. (cherry picked from commit d884a3c)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
If any `print` is necessary for debugging failed test cases, we probably ought to reconfigure the test runner's display mechanisms, or use the built-in configuration of the `unittest` assert methods to produce better results. (cherry picked from commit d884a3c) Co-authored-by: Jake Lishman <[email protected]>
emilkovacev
pushed a commit
to emilkovacev/qiskit
that referenced
this pull request
Feb 7, 2025
If any `print` is necessary for debugging failed test cases, we probably ought to reconfigure the test runner's display mechanisms, or use the built-in configuration of the `unittest` assert methods to produce better results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: None
Do not include in changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
type: qa
Issues and PRs that relate to testing and code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any
print
is necessary for debugging failed test cases, we probably ought to reconfigure the test runner's display mechanisms, or use the built-in configuration of theunittest
assert methods to produce better results.Summary
Details and comments