Pylint configuration to prevent accidentally committing debugging print statements

[1ucian0]

Summary

Adds the bad_builtin extension to pylint and raise a warning when print is used. Add a disable for current cases.

Details and comments

It happens from time to time that we accidentally push for code with debugging print statements. Many times, they are captured during revision. However, sometimes they end up in main. Maybe it helps if pylint tell us.

out-of-scope: evaluate if the current prints are justify. Issues can be submitted for them independently.

[qiskit-bot]

One or more of the following people are relevant to this code:

• @enavarro51
• @Qiskit/terra-core

[jakelishman]

This seems like a reasonable and easy catch for the test suite. We only really rarely use it in library code (mostly just visualisations), so I think it'll probably help more than hurt - it's easy to blanket allow in relevant tools (though it'd be cool if we could more easily configure pylint per directory).

[coveralls]

Pull Request Test Coverage Report for Build 13167960236

Details

• 2 of 6 (33.33%) changed or added relevant lines in 5 files are covered.
• 9 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.003%) to 88.654%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/quantum_info/operators/operator.py	0	1	0.0%
qiskit/quantum_info/states/densitymatrix.py	0	1	0.0%
qiskit/quantum_info/states/statevector.py	0	1	0.0%
qiskit/visualization/circuit/matplotlib.py	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
crates/accelerate/src/unitary_synthesis.rs	1	92.97%
crates/qasm2/src/lex.rs	2	93.23%
crates/qasm2/src/parse.rs	6	97.15%

Totals
Change from base Build 13165103262:	0.003%
Covered Lines:	79232
Relevant Lines:	89372

---

💛 - Coveralls

[1ucian0]

though it'd be cool if we could more easily configure pylint per directory.

I fully agree. However, I'm hesitant if introducing a plugin just for this is worthy.

[jakelishman]

Oh yeah, I don't want a plugin really, I kind of wanted it as a pylint builtin. We should probably put more effort in moving to Ruff properly than trying to fix up pylint at this stage - I think I was the last major hold-out a year ago or so.

I have a semi-decent configuration for the basis-constructor plugin repo that we might be able to bring over to Qiskit, though I'm still nervous that it's not as effective as pylint (but it is a hell of a lot faster).