-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the parameter expression case for RZZ validation #2035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t-imamichi Thanks a lot for the contribution! It's great, I wrote only one small comment.
Co-authored-by: Yael Ben-Haim <[email protected]>
bb0ffd1
to
ff75fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note lint failure. |
I forgot to remove the unnecessary import |
Thank you for your review and comments, @yaelbh. |
* fix parameter expression case for RZZ * Update qiskit_ibm_runtime/utils/utils.py Co-authored-by: Yael Ben-Haim <[email protected]> * black * simplify test * lint --------- Co-authored-by: Yael Ben-Haim <[email protected]>
Summary
The current RZZ validation fails with parameter expression as follows.
0.33.1
this PR
This PR also removes redundant white spaces in the error message
in the range [0, pi/2]
. The full message is as follows.Details and comments
Note that I think this PR needs to be merged to the server side too so that pubs with parameter expressions are processed without error.
E.g.,
cwrsqwf997wg008xfytg
failed with the following error