-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify values of parametrized rzz gates #2021
Open
yaelbh
wants to merge
26
commits into
Qiskit:main
Choose a base branch
from
yaelbh:pvalrzz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+214
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #2035, we should also take into account parameter expressions. |
A couple of comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2000.
This is only a draft. I forgot to write the tests before the code. So the current push contains the logic, but the tests will be added shortly.
Details and comments
@SamFerracin I have a question about the noise learner. I see that
NoiseLearner._run
callsvalidate_isa_circuits
, likeBasePrimitiveV2
. I added inBasePrimitivesV2
a call to a new function,validate_rzz_pubs
. But I'm not familiar enough with the noise learner to figure if a similar call should be added there too. I tried to add, butNoiseLearner._run
receives circuits, unlikeBasePrimitiveV2
, which receives pubs. Should I make_run
receive pubs and add the call to the new function?