-
Notifications
You must be signed in to change notification settings - Fork 2
feat: change schemaIds -> intentIds for Frequency 2.x #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
040b235
8d3e49c
945092a
c5c9d9e
cb4068f
57348d2
ccdd166
54abef6
84605e1
074a98f
67dfaf7
09112ac
e80b550
7db5d88
bee0e69
7094f8e
3f40962
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,10 +24,6 @@ jobs: | |
| publish-npm: | ||
| name: Publish NPM Package | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
| # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ | ||
|
Comment on lines
-27
to
-30
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't make sense to use a matrix here; we only publish one version of the package. I left the matrix in other parts of the pipeline, because it's okay to validate our build on different versions of Node, but for publishing, just like Highlander, there can be only one. |
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -37,9 +33,6 @@ jobs: | |
| with: | ||
| cache-dependency-path: libraries/js/package-lock.json | ||
|
|
||
| - name: Install npm version that supports OIDC auth | ||
| run: npm install -g npm@11.5.1 # Use 'latest' or a specific version number | ||
|
|
||
| - name: Install dependencies | ||
| working-directory: libraries/js | ||
| run: npm ci | ||
|
|
@@ -52,12 +45,18 @@ jobs: | |
| working-directory: libraries/js/dist | ||
| run: npm version --new-version "${{env.NEW_RELEASE_TAG}}" --no-git-tag-version | ||
|
|
||
| # Until we upgrade to Node 24.x across the board, we need npm >= 11.5 to publish using GitHub OAuth | ||
| - name: Install npm 11.x | ||
| working-directory: libraries/js/dist | ||
| shell: bash | ||
| run: npm i -D npm@11.7 | ||
|
|
||
| - name: Release on NPM @latest | ||
| if: env.NPM_LATEST == 'true' | ||
| working-directory: libraries/js/dist | ||
| run: npm publish --tag latest --access public | ||
| run: npx npm@11 publish --tag latest --access public | ||
|
|
||
| - name: Release on NPM without @latest | ||
| if: env.NPM_LATEST != 'true' | ||
| working-directory: libraries/js/dist | ||
| run: npm publish --tag next --access public | ||
| run: npx npm@11 publish --tag next --access public | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |
| build-lib-js: | ||
| strategy: | ||
| matrix: | ||
| node-version: [20.x, 22.x] | ||
| node-version: [22.x] | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed validating against Node 20.x, since it's EOL. Adding support for Node 24.x can be a future task. |
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
|
|
@@ -22,6 +22,7 @@ jobs: | |
| - name: Setup Node and npm | ||
| uses: ./.github/workflows/common/setup-node-and-npm | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache-dependency-path: | | ||
| libraries/js/package-lock.json | ||
| tools/mock-siwf/package-lock.json | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| nodejs 22.11.0 | ||
| nodejs 22.18.0 | ||
| pnpm 8.12.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| book | ||
| package-lock.json | ||
| node_modules | ||
| css/tailwind.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to change the npm version globally, because it causes compatibility issues with the lock files. We only need >= 11.x for the publishing step.