feat: change schemaIds -> intentIds for Frequency 2.x#455
Merged
JoeCap08055 merged 17 commits intomainfrom Feb 6, 2026
Merged
Conversation
JoeCap08055
commented
Feb 5, 2026
| node-version: ${{ inputs.node-version }} | ||
| cache: ${{ inputs.cache }} | ||
| cache-dependency-path: ${{ inputs.cache-dependency-path }} | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We don't want to change the npm version globally, because it causes compatibility issues with the lock files. We only need >= 11.x for the publishing step.
JoeCap08055
commented
Feb 5, 2026
Comment on lines
-27
to
-30
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
| # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ |
Contributor
Author
There was a problem hiding this comment.
Doesn't make sense to use a matrix here; we only publish one version of the package. I left the matrix in other parts of the pipeline, because it's okay to validate our build on different versions of Node, but for publishing, just like Highlander, there can be only one.
JoeCap08055
commented
Feb 5, 2026
| strategy: | ||
| matrix: | ||
| node-version: [20.x, 22.x] | ||
| node-version: [22.x] |
Contributor
Author
There was a problem hiding this comment.
Removed validating against Node 20.x, since it's EOL. Adding support for Node 24.x can be a future task.
shannonwells
approved these changes
Feb 5, 2026
Contributor
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
- reviewed the code changes
- checked out the branch
- built the js lib
- built and ran the mock server
- built and ran js-example tool
- built and ran signed request generator and used it to generate a signature with PolkadotJS extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changes necessary for SIWF to work properly with Frequency 2.x, notably:
AddProviderpayload, change the name of the fieldschemaIds->intentIdsCloses #457