-
Notifications
You must be signed in to change notification settings - Fork 0
Semester Title Customization + Adding Toolbox Placeholder Text #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a message prompting users to add courses when the toolbox is empty, improving user guidance and interface clarity.
Added custom semester titles when adding a new semester and implemented inline editing of semester names in SemesterBlock. The UI now allows users to rename semesters directly, improving planner organization and usability.
Changed the placeholder text opacity from 60% to 50% in the SemesterBlock component for improved visual distinction.
Updated the PlannerCourseHolder component to include opacity-60 and italic styles for improved visual appearance.
Added trailing commas to callback functions in main.tsx and SemesterBlock.tsx to improve code consistency and formatting. No functional changes were made.
Simplified the logic since we do not want the semester titles to have opacity.
ramonechen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge branch main-preview into this one and resolve any conflicts before it can be merged 🙏
Removes unnecessary trailing comma in the useEffect setCount call for improved code clarity.
|
@ramonechen @mirmirmirr |
ramonechen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like that semester names are truncated when past a certain length, depending on available screen size. Can't find any issues with this feature.
Semester Title Customization
Users can now customize the title of their semesters. An edit icon has been added for a more intuitive interface, and a dashed line appears to indicate changes as well. Users can either click on the "Semester 1", "Semester 2", etc. where a dashed line appears to customize the placeholders or click on the edit icon to make changes. Additionally, when a user hovers over the title, directions such as "Click to Rename" and "Edit Semester Name" are added.

Moreover, to match the changes in
Toolboxplaceholder text, the placeholder text for the semesters has changed in opacity and is italic.An example below:
Toolbox Placeholder Text
The

Toolboxchanged to contain placeholder messages, advising users to add courses to the toolbox to proceed. This improves user guidance and interface clarity. The logic implemented is to check whether there are any items in theToolbox. If there isn't, then we can display the placeholder message.