Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concurrency limits): rename and provide examples of task run concurrency limits #362

Merged

Conversation

jimid27
Copy link
Contributor

@jimid27 jimid27 commented Jan 31, 2025

Summary

  • In PR chore/concurrency-limit-support #360 we introduced concurrency limits without much supporting information. What we were actually introducing was task run concurrency limits, which should have been explained to end users.

References

https://app.prefect.cloud/api/docs#tag/Concurrency-Limits

Related to https://linear.app/prefect/issue/PLA-383/add-support-for-concurrency-limits

Notes

  • The concurrency_limits API only supports creating and destroying task run concurrency limits. These concurrency limits are referenced in task definitions and can be called by matching the tag defined in the task run concurrency limit to the tags defined in each task definition. (See example)
  • Task run concurrency limits cannot be updated in place and need to be recreated each time they are updated.

Tests

  • Added unit test to verify that the task run concurrency limit can be created and updated via destroy and recreate.

@jimid27 jimid27 temporarily deployed to Acceptance Tests January 31, 2025 16:50 — with GitHub Actions Inactive
@jimid27 jimid27 marked this pull request as ready for review January 31, 2025 16:50
@jimid27 jimid27 requested a review from a team as a code owner January 31, 2025 16:50
@github-actions github-actions bot added the docs label Jan 31, 2025
@mitchnielsen mitchnielsen added the bugfix Fixing a bug label Jan 31, 2025
@mitchnielsen mitchnielsen changed the title fix(concurrency limits) Rename and provides examples of task run concurrency limits fix(concurrency limits): rename and provide examples of task run concurrency limits Jan 31, 2025
Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix on this one

@jimid27 jimid27 merged commit 70d957a into main Jan 31, 2025
@jimid27 jimid27 deleted the fix/concurrency_limits_v1_to_task_run_concurrency_limits branch January 31, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing a bug docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants