Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/concurrency-limit-support #360

Merged
merged 16 commits into from
Jan 30, 2025
Merged

chore/concurrency-limit-support #360

merged 16 commits into from
Jan 30, 2025

Conversation

jimid27
Copy link
Contributor

@jimid27 jimid27 commented Jan 28, 2025 •
edited
Loading

@jimid27 jimid27 marked this pull request as ready for review January 29, 2025 22:29
@jimid27 jimid27 requested a review from a team as a code owner January 29, 2025 22:29
@github-actions github-actions bot added the docs label Jan 29, 2025
@jimid27 jimid27 temporarily deployed to Acceptance Tests January 29, 2025 22:39 — with GitHub Actions Inactive
@jimid27 jimid27 temporarily deployed to Acceptance Tests January 29, 2025 23:37 — with GitHub Actions Inactive
@jimid27 jimid27 merged commit c2f14e1 into main Jan 30, 2025
@jimid27 jimid27 deleted the chore/concurrency-limit-support branch January 30, 2025 15:47
@jbnitorum
Copy link

Is this for global concurrency limits or task run concurrency limits? I see the API docs look vague as to which they apply to. The former has the additional option of slot decay per second

@mitchnielsen
Copy link
Contributor

Thanks for reaching out, we had a look at the API docs and the correct endpoint in this case appears to actually be the one for Concurrency Limits v2. We're confirming with the backend team and getting a better understanding and then will follow up with change(s) to make this clearer and better supported.

@jimid27 jimid27 mentioned this pull request Jan 31, 2025
Merged
@mitchnielsen
Copy link
Contributor

We've opened #362 to specify that this is for task run concurrency limits. Should have it released soon, and global concurrency limit support will come after that.

@mitchnielsen
Copy link
Contributor

That change is now available in v2.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchnielsen mitchnielsen mitchnielsen approved these changes

Assignees

@jimid27 jimid27

Labels
docs feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimid27 @jbnitorum @mitchnielsen