Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/npm release steps run upon successful npm packaging #7

Merged
merged 1 commit into from
Jan 18, 2024
Merged

chore/npm release steps run upon successful npm packaging #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ runs:
access: public

- name: Create Release
if: ${{ steps.publish.outputs.type }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking if the output is present? or do you need to check if it is something specific

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just if it is present. If a change in the version occurs this will be populated. The docs state:

[Semver release type](https://github.com/npm/node-semver#release_types), initial if first release, different if other change, or empty if no release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it's undefined if no release is created
image

env:
GH_TOKEN: ${{ inputs.GITHUB_TOKEN }}
tag: ${{ steps.publish.outputs.version }}
Expand All @@ -55,7 +56,8 @@ runs:
shell: bash

- name: Trigger Nebula UI NPM Package Update
if: ${{ inputs.UPDATE_DOWNSTREAM_REPOS == 'true' }}
if: |
${{ inputs.UPDATE_DOWNSTREAM_REPOS == 'true' }} && ${{ steps.publish.outputs.type }}
env:
GITHUB_TOKEN: ${{ inputs.NEBULA_UI_ACTIONS_RW_TOKEN }}
tag: ${{ steps.publish.outputs.version }}
Expand All @@ -68,7 +70,8 @@ runs:
shell: bash

- name: Trigger Prefect OSS NPM Package Update
if: ${{ inputs.UPDATE_DOWNSTREAM_REPOS == 'true' }}
if: |
${{ inputs.UPDATE_DOWNSTREAM_REPOS == 'true' }} && ${{ steps.publish.outputs.type }}
env:
GITHUB_TOKEN: ${{ inputs.PREFECT_OSS_ACTIONS_RW_TOKEN }}
tag: ${{ steps.publish.outputs.version }}
Expand Down