chore/npm release steps run upon successful npm packaging #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jimid27
commented
Jan 18, 2024
jimid27
commented
- Relates: https://github.com/PrefectHQ/platform/issues/5517
- Follows step described here
pleek91
approved these changes
Jan 18, 2024
parkedwards
reviewed
Jan 18, 2024
| @@ -44,6 +44,7 @@ runs: | |||
| access: public | |||
|
|
|||
| - name: Create Release | |||
| if: ${{ steps.publish.outputs.type }} | |||
There was a problem hiding this comment.
just checking if the output is present? or do you need to check if it is something specific
There was a problem hiding this comment.
Just if it is present. If a change in the version occurs this will be populated. The docs state:
[Semver release type](https://github.com/npm/node-semver#release_types), initial if first release, different if other change, or empty if no release.
There was a problem hiding this comment.
ah it's undefined if no release is created
parkedwards
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.