Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run full observability check for radial grid without phasor measurement #858

Merged
merged 20 commits into from
Dec 19, 2024
Merged

Run full observability check for radial grid without phasor measurement #858

merged 20 commits into from
Dec 19, 2024

Conversation

TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Dec 15, 2024 •
edited
Loading

Closes #838

Check list:

  • Implement the core
  • Adjust unit test
  • Validation test of a system with enough number of power sensors but they are not independent
  • Adjust documentation, if needed
  • Add fail specification in the validation test

@TonyXiang8787 TonyXiang8787 added feature New feature or request do-not-merge This should not be merged labels Dec 15, 2024
@TonyXiang8787 TonyXiang8787 removed the do-not-merge This should not be merged label Dec 18, 2024
@TonyXiang8787 TonyXiang8787 marked this pull request as ready for review December 18, 2024 13:30
mgovers
mgovers reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to other priorities, i have not yet done a full in-depth review but here are some remarks

docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most looks good to me

docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/observability.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/observability.hpp Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/observability.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/observability.hpp Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/observability.hpp Outdated Show resolved Hide resolved
TonyXiang8787 and others added 2 commits December 18, 2024 16:07
@TonyXiang8787 @Jerry-Jinfeng-Guo
Update power_grid_model_c/power_grid_model/include/power_grid_model/m…
2ba1023 
…ath_solver/observability.hpp

Co-authored-by: Jerry Guo <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 @Jerry-Jinfeng-Guo
Apply suggestions from code review
cc93b84 
Co-authored-by: Jerry Guo <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
TonyXiang8787 and others added 2 commits December 18, 2024 16:19
@TonyXiang8787 @Jerry-Jinfeng-Guo
Update docs/user_manual/calculations.md
a47d83e 
Co-authored-by: Jerry Guo <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
resolve comments'
517d6db 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 @mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/m…
c190e32 
…ath_solver/observability.hpp

Co-authored-by: Martijn Govers <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
Update observability.hpp
9460cd2 
Signed-off-by: Tony Xiang <[email protected]>
TonyXiang8787 and others added 2 commits December 19, 2024 16:10
@TonyXiang8787 @mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/m…
2372f2c 
…ath_solver/observability.hpp

Co-authored-by: Martijn Govers <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 @mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/m…
33bf4b6 
…ath_solver/observability.hpp

Co-authored-by: Martijn Govers <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @mgovers has signed off. I hereby resolve the comments and approve the PR.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 31df226 Dec 19, 2024
28 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/full-observability-radial branch December 19, 2024 16:29
@petersalemink95 petersalemink95 mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Check for necessary and sufficient condition for observability in radial grid
3 participants
@TonyXiang8787 @Jerry-Jinfeng-Guo @mgovers