perf(dashboards): load the dashboard modals when they open by pauldambra · Pull Request #110353 · PostHog/posthog

pauldambra · 2026-10-01T21:24:09Z

🤖 A robot (Claude Code) wrote this PR. The assignee directed the work.

Problem

Every dashboard downloads the add widget, subscriptions, sharing and Terraform export modals, which render closed but carry their editors and integration setup.

Related: #110351, #110352, #110354, #110355, #110356

Changes

Each of the four modals loads lazily and mounts only while it is open. A modal can take a moment longer to appear the first time it opens.
useKeepMountedWhileOpen keeps each one mounted through its exit animation, as GlobalModals does.
The dashboard scene's ChunkLoadErrorBoundary is the nearest boundary, so a stale chunk reloads the page as it does for a scene.

Together the six PRs cut the dashboard scene from 11.66 to 9.62 MiB (−2.04 MiB), events from 10.89 to 9.23 MiB, replay detail from 13.77 to 12.06 MiB, and project home from 14.43 to 13.89 MiB (minified, linked stylesheet included, same master build). Several modules have more than one importer, so part of the saving appears only once all six land.

On its own this PR removes about 350 KB from the dashboard scene, and about 1 MB in combination with the others.

How did you test this code?

Typecheck passes, and the dashboard suites pass.
No story opens these modals through the dashboard route; their own stories render the components directly.
Not checked: opening each modal in a browser.

Test rationale: No new test. The modals keep their props and open state, and their own stories cover how they render.

Release status

No feature flag controls this change
This change is behind a feature flag and is not available to users
This change makes a previously flagged feature available to everyone

Automatic notifications

Publish to changelog?

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Opus 5.5 (claude-opus-5-5)

One of six sibling PRs off master that cut the logged-in scene graphs, found with a dominator tree over the esbuild metafile and checked by simulating each cut.
The review checklist from the chore(frontend): measure the eager graph of the busiest scenes #110093–perf(aio): load the global column renderers on first use #110095 stack was applied before opening: lazyWithRetry for every dynamic import, a ChunkLoadErrorBoundary with a fallback inside query and card error boundaries, and loading only on open or expand.
Skills invoked: /writing-code-comments.
Duplicate search: gh pr list --state open found no PR that does this.

Created with PostHog Desktop

🤖 Generated with Claude Code

DashboardModals rendered the add widget, subscriptions, sharing and Terraform export modals closed on every dashboard, so their editors and integration setup sat on the dashboard scene's static graph. Each one is now a lazy import that mounts only while open, and stays mounted through its exit animation with useKeepMountedWhileOpen, as GlobalModals does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: acec8cb2-f000-4747-a659-05b72b42513e

trunk-io · 2026-10-01T21:24:13Z

😎 Merged successfully - details.

posthog · 2026-10-01T21:24:15Z

FLASH MODE - Faster, but stupid, use regular ReviewHog for a heavy review

🦔 PostHog Review reviewed this pull request

Nothing worth raising this time. Enjoy the moment:

github-actions · 2026-10-01T21:26:17Z

🤖 CI report

✅ Trunk lane — non-backend lane

This PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes.

⚠️

Complexity (TypeScript) — 1 function above the limit (max 24)

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

Function	Location	Complexity	Limit
`DashboardModals`	`frontend/src/scenes/dashboard/DashboardModals.tsx:42`	24	10

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

⚠️

Comment density — 3% of added code lines are comments (5 of 149)

This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.

Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.

Files with the most added comment lines:

File	Comment lines	Added lines
`frontend/src/scenes/dashboard/DashboardModalLoading.tsx`	3	29
`frontend/src/scenes/dashboard/DashboardModals.tsx`	2	102

This check does not block merging. It updates on every push and clears when the share drops.

⚠️

Bundle size — 🔺 +173.2 KiB (+0.2%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 70.85 MiB · 🔺 +173.2 KiB (+0.2%)

File	Size	Δ vs base
`exporter/_parent/products/subscriptions/frontend/components/Subscriptions/SubscriptionsModal.js`	74.1 KiB	🔺 +74.1 KiB (new)
`posthog-app/_parent/products/dashboards/frontend/widgets/AddWidgetModal.js`	24.8 KiB	🔺 +24.8 KiB (new)
`exporter/_parent/products/dashboards/frontend/widgets/AddWidgetModal.js`	22.0 KiB	🔺 +22.0 KiB (new)
`exporter/src/lib/components/TerraformExporter/TerraformExportModal.js`	17.3 KiB	🔺 +17.3 KiB (new)
`posthog-app/_parent/products/subscriptions/frontend/components/Subscriptions/SubscriptionsModal.js`	4.8 KiB	🔺 +4.8 KiB (new)
`render-query/src/render-query/render-query.js`	20.23 MiB	🔺 +4.4 KiB (+0.0%)
`posthog-app/src/lib/components/Sharing/SharingModal.js`	3.6 KiB	🔺 +3.6 KiB (new)
`posthog-app/src/scenes/dashboard/dashboards/Dashboards.js`	38.5 KiB	🟢 -3.0 KiB (-7.2%)
`exporter/src/lib/components/Sharing/SharingModal.js`	2.3 KiB	🔺 +2.3 KiB (new)
`posthog-app/_parent/products/metrics/frontend/MetricsScene.js`	96.0 KiB	🔺 +1.2 KiB (+1.3%)
`posthog-app/src/scenes/dashboard/Dashboard.js`	13.3 KiB	🟢 -1.0 KiB (-7.2%)

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root	Eager (shipped)	Δ vs base	Budget
entry (logged-out pages, app bootstrap) `src/index.tsx`	1.62 MiB · 22 files	🔺 +1 B (+0.0%)	`█████████░` 87.9% of 1.84 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login) `src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts`	3.58 MiB · 630 files	🔺 +1.1 KiB (+0.0%)	`█████████░` 88.7% of 4.03 MiB
authenticated shell (every logged-in page) `src/scenes/AuthenticatedShell.tsx`	7.75 MiB · 2,486 files	🔺 +2.2 KiB (+0.0%)	`█████████░` 93.0% of 8.34 MiB
dashboard scene `src/scenes/dashboard/Dashboard.tsx`	11.30 MiB · 4,292 files	🟢 -367.8 KiB (-3.1%)	`████████░░` 83.9% of 13.48 MiB
project home scene `src/scenes/project-homepage/ProjectHomepage.tsx`	14.44 MiB · 5,365 files	🔺 +16.2 KiB (+0.1%)	`█████████░` 87.8% of 16.44 MiB
events scene `src/scenes/activity/explore/EventsScene.tsx`	10.90 MiB · 4,134 files	🔺 +8.5 KiB (+0.1%)	`█████████░` 86.3% of 12.64 MiB
replay detail scene `src/scenes/session-recordings/detail/SessionRecordingDetail.tsx`	13.79 MiB · 5,056 files	🔺 +16.2 KiB (+0.1%)	`█████████░` 87.7% of 15.72 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx

Size	File
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
24.6 KiB	`../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js`
6.3 KiB	`../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js`
4.5 KiB	`../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js`
3.9 KiB	`../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js`
1.4 KiB	`../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js`
1.3 KiB	`src/index.tsx`
1.3 KiB	`src/RootErrorBoundary.tsx`
912 B	`../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js`
854 B	`src/scenes/ChunkLoadErrorBoundary.tsx`

Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
100.5 KiB	`src/lib/api.ts`
91.9 KiB	`src/products.tsx`
69.4 KiB	`src/lib/lemon-ui/icons/icons.tsx`
40.1 KiB	`src/lib/utils/eventUsageLogic.ts`
38.7 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
33.9 KiB	`../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`
28.7 KiB	`src/scenes/scenes.ts`

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
91.9 KiB	`src/products.tsx`
90.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`

Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/project-homepage/ProjectHomepage.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

✅ Toolbar bundle — eager 2.19 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric	Size	Δ vs base	Budget
Eager (shipped) entry + static imports	2.19 MiB · 19 files	🔺 +331 B (+0.0%)	`████░░░░░░` 38.3% of 5.72 MiB
Deferred (lazy)	2.10 MiB · 44 files	no change	n/a — loads on demand
Loader `dist/toolbar.js`	1.2 KiB	no change	`█░░░░░░░░░` 6.0% of 19.5 KiB

Largest eagerly-shipped chunks

Size	File
830.3 KiB	`dist/toolbar/toolbar-app-JYLOHLGI.css`
657.1 KiB	`dist/toolbar/chunk-chunk-6PGJOX6X.js`
259.4 KiB	`dist/toolbar/chunk-chunk-VJB3SXU4.js`
138.2 KiB	`dist/toolbar/chunk-chunk-FMTPJS5R.js`
131.8 KiB	`dist/toolbar/chunk-chunk-FDH2IBXT.js`
75.2 KiB	`dist/toolbar/toolbar-app-5IKUZTIC.js`
69.0 KiB	`dist/toolbar/chunk-chunk-TSAL54PB.js`
35.6 KiB	`dist/toolbar/chunk-chunk-AXBVQLMJ.js`
21.0 KiB	`dist/toolbar/chunk-chunk-KBIC7JXJ.js`
6.8 KiB	`dist/toolbar/chunk-chunk-DV7IWQNF.js`

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

✅ Dist folder size — 🔺 +437.4 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 965.94 MiB · 🔺 +437.4 KiB (+0.0%)

✅ Playwright — all passed

All tests passed.

View test results →

chatgpt-codex-connector · 2026-10-01T21:26:56Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-01T21:30:23.636042Z	`f4ae287`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-10-01T21:27:01Z

🦔 Hogbox preview · ✅ ready

▶ Open the preview


🔑 Login	`test@posthog.com` / `12345678` (demo data)
🧩 Running	this PR's backend and frontend, on the PostHog `:master` base
🔗 Link	stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access	tailnet only (PostHog VPN)
🛠️ Admin	inspect & debug state in hogland
💤 Idle	sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

_{commit 8c4e498 · box box-47ce4689a4a4 · ready in 721s (push → usable) · build log · rebuilds on every push, torn down on close}

posthog · 2026-10-01T21:29:37Z

FLASH MODE - Faster, but stupid, use regular ReviewHog for a heavy review
PostHog Review alpha 🦔 If you find any issues helpful - please reply "valid", "invalid", etc., for evaluation purposes 🙏

posthog

FLASH MODE - Faster, but stupid, use regular ReviewHog for a heavy review

PostHog Review

Found 1 consider.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4ae2876a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderabbitai · 2026-10-01T21:30:24Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (11)

.cursor/rules/react-typescript.mdc — auto-discovered
.agents/skills/using-kea-disposables/SKILL.md — configured
.agents/skills/writing-ui-components/SKILL.md — configured
.agents/security.md — configured
docs/published/handbook/engineering/type-system.md — configured
.agents/skills/adopting-generated-api-types/SKILL.md — configured
.agents/skills/placing-product-frontend-code/SKILL.md — configured
.claude/commands/conventions.md — configured
.agents/skills/writing-kea-logics/SKILL.md — configured
.agents/skills/writing-user-facing-copy/SKILL.md — configured
.agents/skills/writing-code-comments/SKILL.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: c06b6da7-4118-4c85-9e28-4ce5e519c8ce

📥 Commits

Reviewing files that changed from the base of the PR and between eb87b76 and 8c4e498.

📒 Files selected for processing (1)

frontend/src/scenes/dashboard/DashboardModalLoading.tsx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

DashboardModals lazy-loads Add Widget, Sharing, Subscriptions, and Terraform Export with retry support. Each modal renders under Suspense with a delayed loading-modal fallback and remains mounted through its closing transition. Add Widget remains gated by the dashboard widgets setting. Sharing opens in Sharing mode.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 8c4e4

Screen-reader users may not be told that a dashboard modal is loading, though visual loading feedback and chunk-error recovery remain available. This is a bounded accessibility gap; the rest of the change appears mergeable with that limitation understood.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 8c4e4

The reviewed changes defer existing dashboard dialogs without adding privileges or weakening their existing controls. Loading remains presentation-only, closing remains authoritative, and failed downloads use the existing recovery path.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The demonstrated change is confined to dashboard dialogs in the frontend session. The new fallback adds neither a data-store operation nor an independently privileged action; existing dashboard mutation and export paths retain their prior inputs.

Trust Boundaries and Controls

observed — Loading text is rendered as a React attribute, import destinations are fixed literals, and the fallback delegates closing to its caller. No dynamic import destination, credential handling, or new authorization decision appears in this entrypoint.

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description follows the required structure and clearly explains the problem, user-visible changes, testing status, release status, and agent context. It omits screenshots for the frontend changes …

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

_{Comment @coderabbitai help to get the list of available commands.}

trunk-io · 2026-10-01T21:40:16Z

_{View Full Report ↗︎ ⋅ Docs}

The lazy dashboard modals used a null Suspense fallback, so on a cold cache the click that opened one had no visible response and nothing to close until the chunk arrived. Each boundary now falls back to DashboardModalLoading, a spinner modal that takes the real modal's open state and close action. It waits briefly before it appears, so a cached chunk swaps straight to the real modal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: acec8cb2-f000-4747-a659-05b72b42513e

parameterai · 2026-10-01T22:11:36Z

Risk: No findings

This increment adds an accessible loading announcement to the dashboard modal Suspense fallback: a static label prop rendered as role="status" with aria-label. It changes no security-relevant behavior; all labels are developer-authored constants, and the lazy-load gating and close handlers are unchanged.

_{Sentinel reviewed 8c4e498 · Review settings}

posthog

FLASH MODE - Faster, but stupid, use regular ReviewHog for a heavy review

PostHog Review

Found 1 should fix.

pauldambra · 2026-10-01T22:22:08Z

Note

🤖 Automated comment by QA Swarm — not written by a human

Router pass over the full diff, then a second pass over the fix commits. No delegated lenses: danger graded LOW.

Verdict: ✅ APPROVE _{(@ eb87b76)}

No findings. ReviewHog and Codex asked for loading feedback while a modal chunk downloads; fixed in eb87b76. Re-review confirmed closing during the load works through the useKeepMountedWhileOpen grace period. A NIT asking for a keep-mounted test was skipped: the hook is shared and used the same way in GlobalModals.

Checked against the lazy-load checklist from the #110093–#110095 reviews: lazyWithRetry for every dynamic import, a ChunkLoadErrorBoundary with a fallback inside query and card error boundaries, loading only on open or expand, no change to modal props or styles, and no imports left at moved paths.

Automated by QA Swarm — not a human review

The loading modal showed a bare spinner with no accessible name, so a screen reader got no loading announcement while a modal chunk downloaded. It now wraps the spinner in a role="status" region named from a label prop, defaulting to "Loading". The file stays byte-identical to the copy in the sibling add-insight PR, so the two still merge cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: acec8cb2-f000-4747-a659-05b72b42513e

A new stamphog review started for this PR — the fresh verdict replaces this approval.

stamphog

Approved.

Contained frontend performance change that lazy-loads four dashboard modals. It uses existing helpers (lazyWithRetry, useKeepMountedWhileOpen) and leaves modal props and open-state logic unchanged. Nothing falls in risky territory, and the reviewers' feedback was addressed with a loading fallback.

Author wrote 0% of the modified lines and has 17 merged PRs in these paths (familiarity MODERATE).

Gate mechanics and policy version

Gate		Result
prerequisites	✓	all clear
deny-list	✓	no deny categories matched
size	✓	175L, 2F substantive, 201L/3F incl. docs/generated/snapshots — within ceiling
tier	✓	T1-agent / T1c-medium (201L, 3F, single-area, perf)
stamphog 2.3.1		`.stamphog/policy.yml` @ `8c4e498` · reviewed head `8c4e498`

deployment-status-posthog · 2026-10-02T09:51:57Z

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-10-02 09:51 UTC	Run
prod-us	✅ Deployed	2026-10-02 10:01 UTC	Run
prod-eu	✅ Deployed	2026-10-02 10:03 UTC	Run

pauldambra self-assigned this Oct 1, 2026

pauldambra marked this pull request as ready for review October 1, 2026 21:26

github-actions Bot deployed to preview-pr-110353 October 1, 2026 21:26 View deployment

pr-assigner-resolver-posthog Bot requested a review from a team October 1, 2026 21:27

posthog Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread frontend/src/scenes/dashboard/DashboardModals.tsx Outdated

chatgpt-codex-connector Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread frontend/src/scenes/dashboard/DashboardModals.tsx Outdated

github-actions Bot deployed to preview-pr-110353 October 1, 2026 22:10 View deployment

posthog Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread frontend/src/scenes/dashboard/DashboardModalLoading.tsx Outdated

pauldambra added the stamphog Request AI approval (no full review) label Oct 1, 2026 — with PostHog

This comment was marked as outdated.

Sign in to view

github-actions Bot deployed to preview-pr-110353 October 1, 2026 22:34 View deployment

pauldambra removed the stamphog Request AI approval (no full review) label Oct 1, 2026

pauldambra added the stamphog Request AI approval (no full review) label Oct 1, 2026 — with PostHog

stamphog Bot approved these changes Oct 1, 2026

View reviewed changes

trunk-io Bot merged commit f23649f into master Oct 2, 2026
266 checks passed

trunk-io Bot deleted the posthog/lazy-dashboard-modals branch October 2, 2026 09:23

Conversation

pauldambra commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Release status

Automatic notifications

Docs update

🤖 Agent context

Uh oh!

trunk-io Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

posthog Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦔 PostHog Review reviewed this pull request

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

chatgpt-codex-connector Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦔 Hogbox preview · ✅ ready

▶ Open the preview

Uh oh!

posthog Bot commented Oct 1, 2026

Uh oh!

posthog Bot left a comment

Choose a reason for hiding this comment

PostHog Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Security Architecture Review

Uh oh!

trunk-io Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parameterai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

posthog Bot left a comment

Choose a reason for hiding this comment

PostHog Review

Uh oh!

Uh oh!

pauldambra commented Oct 1, 2026

Verdict: ✅ APPROVE (@ eb87b76)

Uh oh!

This comment was marked as outdated.

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

deployment-status-posthog Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy status

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

pauldambra commented Oct 1, 2026 •

edited

Loading

trunk-io Bot commented Oct 1, 2026 •

edited

Loading

posthog Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

trunk-io Bot commented Oct 1, 2026 •

edited

Loading

parameterai Bot commented Oct 1, 2026 •

edited

Loading

Verdict: ✅ APPROVE _{(@ eb87b76)}

deployment-status-posthog Bot commented Oct 2, 2026 •

edited

Loading