-
Notifications
You must be signed in to change notification settings - Fork 201
Fix good first issues: parameterize MT deduction rate and remove confusing comment #6650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxGhenis
wants to merge
12
commits into
PolicyEngine:master
Choose a base branch
from
MaxGhenis:fix-good-first-issues-clean
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
84a007b
Fix good first issues: parameterize MT deduction rate and remove conf…
MaxGhenis a377cf8
Simplify parameter access per code review
MaxGhenis 667aed0
Add changelog entry
MaxGhenis dcd6c87
Add label and improve description to active voice for MT spouse alloc…
MaxGhenis abe8912
Cite specific subsection (2) in MT statute reference
MaxGhenis d105b58
Update parameter-architect agent with label and active voice requirem…
MaxGhenis b58933c
Reframe label/active voice as RECOMMENDED not CRITICAL
MaxGhenis 3327439
Fix statutory citation to correct subsection (1)(c)(vi)(D)
MaxGhenis f0006e1
Reference tax form as primary source (no specific subsection found in…
MaxGhenis fe97f78
Enhance reference-validator with subsection corroboration requirements
MaxGhenis f0fd2e5
Update references with sources that actually corroborate 50% allocati…
MaxGhenis ea5f23c
Remove null value and use Montana Form 2 Instructions as primary refe…
MaxGhenis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| - bump: patch | ||
| changes: | ||
| changed: | ||
| - Parameterized Montana spouse allocation factor for itemized deductions (was hardcoded 0.5) | ||
| removed: | ||
| - Unhelpful comment from .github/update_api.py |
9 changes: 9 additions & 0 deletions
9
...ne_us/parameters/gov/states/mt/tax/income/deductions/itemized/spouse_allocation_rate.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| description: Montana divides itemized deductions equally between spouses when married filing separately on the same form. | ||
| values: | ||
| 2022-01-01: 0.5 | ||
| metadata: | ||
| label: Montana itemized deductions spouse allocation rate | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add period |
||
| unit: /1 | ||
| reference: | ||
| - title: Montana Form 2 Instructions - Itemized deductions divided equally for MFS on same form | ||
| href: https://revenue.mt.gov/publications/montana-form-2-individual-income-tax-return-forms-and-instructions-includes-form-2ec | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add a comment stating that it is not an actual policy parameter |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need 2021 start date to not break 2021 runs