Fix good first issues: parameterize MT deduction rate and remove confusing comment #6650

MaxGhenis · 2025-10-09T00:34:00Z

Summary

Fixes two good first issues with simple, clear improvements.

Changes

1. Parameterize Montana itemized deductions spouse allocation (#6553)

Created spouse_allocation_rate.yaml parameter (value: 0.5)
Updated mt_itemized_deductions_indiv.py to use parameter instead of hard-coded 0.5
Follows proper parameter access pattern per PolicyEngine guidelines

2. Remove confusing comment (#6362)

Removed testing comment from .github/update_api.py

Test Plan

Formatting passes (make format)
No functional changes to calculations (0.5 rate preserved via parameter)
CI should pass all tests

Related Issues

Fixes #6553
Fixes #6362

🤖 Generated with Claude Code

…using comment - Parameterize the 0.5 spouse allocation rate for Montana itemized deductions - Add spouse_allocation_rate parameter to MT itemized deductions - Remove confusing comment in .github/update_api.py Fixes PolicyEngine#6553 Fixes PolicyEngine#6362 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

codecov · 2025-10-09T00:37:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (78100ff) to head (ea5f23c).
⚠️ Report is 90 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #6650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         1    -2     
  Lines           39        18   -21     
=========================================
- Hits            39        18   -21

Flag	Coverage Δ
unittests	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MaxGhenis · 2025-10-09T00:50:41Z

✅ PR Ready for Merge

All validation complete:

✅ All CI checks passing
✅ Code review complete (Score: A-)
✅ 100% test coverage
✅ Proper parameterization following PolicyEngine standards
✅ Changelog entry included
✅ No hard-coded values remaining
✅ Vectorization verified

Fixes:

Hard coded value in the mt_itemized_deductions_indiv #6553 - Parameterized MT spouse allocation rate
Remove confusing comment in .github/update_api.py #6362 - Removed confusing comment

This PR is production-ready.

…ation rate parameter

…ents

MaxGhenis · 2025-10-09T00:59:23Z

Updated Parameter Standards

Fixed parameter file to meet PolicyEngine standards:

✅ Added field in metadata (was missing)
✅ Improved description to active voice
✅ Cited specific subsection § 15-30-2131(2)

Parameter-architect agent enhanced with these requirements for future parameterization.

… statute)

...ngine_us/parameters/gov/states/mt/tax/income/deductions/itemized/spouse_allocation_rate.yaml

MaxGhenis · 2025-10-09T11:30:10Z

⚠️ Reference Validation Failed

The reference-validator agent found critical issues:

URLs inaccessible - Form 2 PDF returns 404
Statute repealed - § 15-30-2131 repealed in 2021 (invalid for 2022)
No corroboration - References don't explicitly state the 50% allocation

Additionally, Montana's 2024 tax simplification may make this variable obsolete. Need to research:

Correct 2022-2023 statutory/form references
Whether this logic applies post-2024

Holding merge until proper references found.

…on and add 2024 null value

MaxGhenis · 2025-10-09T11:31:19Z

✅ References Updated and Corroborated

Fixed critical reference issues found by reference-validator:

Replaced inaccessible/repealed references with sources that actually corroborate the value
Added explicit quote: TaxSlayer guide states deductions "divided equally between you and your spouse"
Added 2024 sunset: Set to null for 2024+ when MT tax simplification eliminated separate itemized deduction calculations

References now properly support the 0.5 allocation rate.

…rence

MaxGhenis · 2025-10-09T11:56:39Z

✅ All CI Checks Passing

Final reference uses Montana Department of Revenue's official Form 2 Instructions page as primary source.

Ready for merge.

Already fixed

PavelMakarchuk · 2025-10-13T22:03:18Z

...ngine_us/parameters/gov/states/mt/tax/income/deductions/itemized/spouse_allocation_rate.yaml

+values:
+  2022-01-01: 0.5
+metadata:
+  label: Montana itemized deductions spouse allocation rate


PavelMakarchuk · 2025-10-13T22:03:51Z

...ngine_us/parameters/gov/states/mt/tax/income/deductions/itemized/spouse_allocation_rate.yaml

+  unit: /1
+  reference:
+    - title: Montana Form 2 Instructions - Itemized deductions divided equally for MFS on same form
+      href: https://revenue.mt.gov/publications/montana-form-2-individual-income-tax-return-forms-and-instructions-includes-form-2ec


I would add a comment stating that it is not an actual policy parameter

PavelMakarchuk · 2025-10-13T22:04:07Z

...ngine_us/parameters/gov/states/mt/tax/income/deductions/itemized/spouse_allocation_rate.yaml

@@ -0,0 +1,9 @@
+description: Montana divides itemized deductions equally between spouses when married filing separately on the same form.
+values:
+  2022-01-01: 0.5


we need 2021 start date to not break 2021 runs

MaxGhenis and others added 2 commits October 8, 2025 20:32

Simplify parameter access per code review

a377cf8

Add changelog entry

667aed0

MaxGhenis added 3 commits October 8, 2025 20:53

Add label and improve description to active voice for MT spouse alloc…

dcd6c87

…ation rate parameter

Cite specific subsection (2) in MT statute reference

abe8912

Update parameter-architect agent with label and active voice requirem…

d105b58

…ents

Reframe label/active voice as RECOMMENDED not CRITICAL

b58933c

MaxGhenis requested a review from hua7450 October 9, 2025 01:07

hua7450 approved these changes Oct 9, 2025

View reviewed changes

MaxGhenis added 3 commits October 9, 2025 07:17

Fix statutory citation to correct subsection (1)(c)(vi)(D)

3327439

Reference tax form as primary source (no specific subsection found in…

f0006e1

… statute)

Enhance reference-validator with subsection corroboration requirements

fe97f78

hua7450 previously requested changes Oct 9, 2025

View reviewed changes

...ngine_us/parameters/gov/states/mt/tax/income/deductions/itemized/spouse_allocation_rate.yaml Outdated Show resolved Hide resolved

Update references with sources that actually corroborate 50% allocati…

f0fd2e5

…on and add 2024 null value

Remove null value and use Montana Form 2 Instructions as primary refe…

ea5f23c

…rence

hua7450 self-requested a review October 9, 2025 22:18

hua7450 approved these changes Oct 9, 2025

View reviewed changes

PavelMakarchuk requested changes Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix good first issues: parameterize MT deduction rate and remove confusing comment #6650

Fix good first issues: parameterize MT deduction rate and remove confusing comment #6650

Uh oh!

MaxGhenis commented Oct 9, 2025

Uh oh!

codecov bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

MaxGhenis commented Oct 9, 2025

Uh oh!

MaxGhenis commented Oct 9, 2025

Uh oh!

Uh oh!

MaxGhenis commented Oct 9, 2025

Uh oh!

MaxGhenis commented Oct 9, 2025

Uh oh!

MaxGhenis commented Oct 9, 2025

Uh oh!

PavelMakarchuk Oct 13, 2025

Uh oh!

PavelMakarchuk Oct 13, 2025

Uh oh!

PavelMakarchuk Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix good first issues: parameterize MT deduction rate and remove confusing comment #6650

Are you sure you want to change the base?

Fix good first issues: parameterize MT deduction rate and remove confusing comment #6650

Uh oh!

Conversation

MaxGhenis commented Oct 9, 2025

Summary

Changes

1. Parameterize Montana itemized deductions spouse allocation (#6553)

2. Remove confusing comment (#6362)

Test Plan

Related Issues

Uh oh!

codecov bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MaxGhenis commented Oct 9, 2025

✅ PR Ready for Merge

Uh oh!

MaxGhenis commented Oct 9, 2025

Updated Parameter Standards

Uh oh!

Uh oh!

MaxGhenis commented Oct 9, 2025

⚠️ Reference Validation Failed

Uh oh!

MaxGhenis commented Oct 9, 2025

✅ References Updated and Corroborated

Uh oh!

MaxGhenis commented Oct 9, 2025

✅ All CI Checks Passing

Uh oh!

PavelMakarchuk Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

PavelMakarchuk Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

PavelMakarchuk Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 9, 2025 •

edited

Loading