Skip to content

add private file#513

Open
givetimetolife wants to merge 2 commits intoPlasticSCM:masterfrom
givetimetolife:master_featres_1
Open

add private file#513
givetimetolife wants to merge 2 commits intoPlasticSCM:masterfrom
givetimetolife:master_featres_1

Conversation

@givetimetolife
Copy link

add private file

@mig42
Copy link
Contributor

mig42 commented Nov 4, 2024

Hi, the command implementation looks good at a first glance, though there are a few linting issues to fix. We'd need some tests to ensure that it doesn't break in the future, too.

Additionally, the proposal is to add the Add command to all items in the changes list. That should only apply to private items, as is the intention of the PR and the expected usage of the command. The problem is, the status refresh only returns items under version control currently, because we didn't have the add functionality. So we'd have to sort that before moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants