WIP: new featres: 1. Supports optional file check-in 2. add a new/private …

[givetimetolife]

1. supports optional file check-in
2. add a new/private file to source control
3. support undo file

[SRombautsU]

Hey @givetimetolife, thanks a lot for your enthusiasm and your work :)

I wanted to let you know that we are planning to give a look to this, @mig42 messaged me to discuss the topic together. Please be patient with us and we are going to come back to you*;

But before we even start to dive seriously into this PR to give you feedback, do you think that you could split the work in smaller bits?
It would be awesome if instead of 1 big PR touching 26 files we could start with just one of the 3 features (focused, with the minimal changes)
For this you can open as many PR as needed, the smaller the faster we can review and merge them (within reason, especially when there are too many dependencies)

Cheers!
Sébastien

[givetimetolife]

ok, next week i will find time to make this. Cheers!

[mig42]

Hi @givetimetolife,

Building on top of what @SRombautsU said, there's some issues to address within your approach:

• Implementations of ICmParser<T> should handle output and error lines
• The "remove from staging" action is effectively calling undo or unco, which means reverting items to their controlled state
  • This could cause loss of data to users
  • As a result, this should display the same warning as the undo command you implemented for the extension
• You can actually use always cm undo for all items, instead of cm unco for checked-out items and cm undo for everything else

We look forward to seeing this PR split up in smaller PRs to give more precise feedback.

Thank you so much for your contribution!

[givetimetolife]

Hi, bro, I'm sorry. I was busy with work some time ago and didn't have time to maintain this function. Now I finally have time. I will continue to maintain and complete this requirement. Thank you for your support.

Let's divide this requirement into several small requirements, and then implement them step by step. In order to facilitate code review and later maintenance.

1. Add new files to version control PR