Adapt to perl 5.37.1 #304
Open
Adapt to perl 5.37.1 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perl 5.37.1 removed a deprecated sv_nv() macro and SDL fails to build
with Perl 5.38.0:
lib/SDLx/Controller/Interface.xs:60:26: error: implicit declaration of function 'sv_nv'
60 | out->dv_x = sv_nv(temp);
| ^~~~~
Users are advised to use SvNVx() macro instead. SvNVx() seems to have been
available all the time (it predates a commit from 1993-10-07).
This patch does that.
PerlGameDev#303
stigtsp
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Sep 21, 2023
This applies the patch from [1], fixing the most important game in nixpkgs. [1]: PerlGameDev/SDL#304
toastal
pushed a commit
to toastal/nixpkgs
that referenced
this pull request
Sep 25, 2023
This applies the patch from [1], fixing the most important game in nixpkgs. [1]: PerlGameDev/SDL#304
lanodan
added a commit
to lanodan/gentoo
that referenced
this pull request
Oct 13, 2023
https: //github.com/PerlGameDev/SDL/pull/304 Signed-off-by: Haelwenn (lanodan) Monnier <[email protected]>
lanodan
added a commit
to lanodan/gentoo
that referenced
this pull request
Oct 13, 2023
Taken from PerlGameDev/SDL#304 Signed-off-by: Haelwenn (lanodan) Monnier <[email protected]>
lanodan
added a commit
to lanodan/gentoo
that referenced
this pull request
Oct 15, 2023
https: //github.com/PerlGameDev/SDL/pull/304 Signed-off-by: Haelwenn (lanodan) Monnier <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 16, 2023
Taken from PerlGameDev/SDL#304 Signed-off-by: Haelwenn (lanodan) Monnier <[email protected]> Closes: #33317 Signed-off-by: James Le Cuirot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl 5.37.1 removed a deprecated sv_nv() macro and SDL fails to build with Perl 5.38.0:
Users are advised to use SvNVx() macro instead. SvNVx() seems to have been available all the time (it predates a commit from 1993-10-07).
This patch does that.
#303