refactored src/screens/FundCampaignPledge from jest to vitest #3208
Conversation
WalkthroughThis pull request focuses on refactoring the test suite for the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/screens/FundCampaignPledge/FundCampaignPledge.spec.tsx (1)
77-86: Consider optimizing the router mock implementationWhile the mock is functional, it could be more efficient. Consider this improvement:
- vi.mock('react-router-dom', async () => { - const actual = await vi.importActual('react-router-dom'); - return { - ...actual, - useParams: () => ({ ...mockParamsState }), - useNavigate: () => mockNavigate, - }; - }); + vi.mock('react-router-dom', async () => ({ + ...(await vi.importActual<typeof import('react-router-dom')>('react-router-dom')), + useParams: () => ({ ...mockParamsState }), + useNavigate: () => mockNavigate, + }));
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/screens/FundCampaignPledge/FundCampaignPledge.spec.tsx(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (5)
src/screens/FundCampaignPledge/FundCampaignPledge.spec.tsx (5)
5-5: LGTM! Clean import consolidationGood job consolidating the testing library imports. The removal of
cleanupis correct as Vitest handles cleanup automatically.
21-33: Well-structured mock implementationsThe migration of mocks from Jest to Vitest is well done:
- Proper use of
vi.fn()for toast methods- Correct implementation of
vi.importActualfor DateTimePicker
44-47: Good test state isolationWell-structured mock state object that provides good test isolation and matches the test requirements.
88-94: Well-implemented test lifecycle hooksGood implementation of test lifecycle hooks:
- Proper use of beforeEach for test isolation
- Correct migration to vi.clearAllMocks()
Line range hint
96-300: Overall excellent migration to VitestThe test suite has been successfully migrated to Vitest while maintaining:
- Complete test coverage
- Original test logic and assertions
- Proper test isolation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3208 +/- ##
=====================================================
+ Coverage 16.54% 89.85% +73.31%
=====================================================
Files 308 329 +21
Lines 7810 8526 +716
Branches 1701 1854 +153
=====================================================
+ Hits 1292 7661 +6369
+ Misses 6429 633 -5796
- Partials 89 232 +143 ☔ View full report in Codecov by Sentry. |
palisadoes
merged commit c15be0e
into
PalisadoesFoundation:develop-postgres
* prevented unnecessary page reload with complementary test * Update jest.config.js * Fixes #2986 - Multiple UI Updates (#3165) * UI fixes on organisation pages * Added TSDoc for Truncated Text * Added Debouncer * Update src/components/OrgListCard/OrgListCard.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Added code rabbit suggestions * Fixed test error --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactore src/screens/OrgList from jest to vitest (#3200) * Improved Code Coverage in src/components/Venues/VenueModal.tsx (#3203) * Improved Code Coverage in src/components/Venues/VenueModal.tsx * removed the ignore statements from VenueModal.tsx * Removed istanbul ignore lines. Code coverage remians 100% (#3207) * refactored src/screens/FundCampaignPledge from jest to vitest (#3208) * prettier formatting and disabled ts-specific rules for js in eslint (#3186) * Improve Code Coverage in src/screens/UserPortal/Settings/Settings.tsx (#3189) * Preventing Overflow of images in Advertisement and Venue Post modals (#3204) * improve code coverage of src/screens/EventManagement (#3149) * code coverage * jest global coverage decreased * global jest coverage * rename file problem solved * changes requested resolved * fix: update Chat section title to 'Chats' (#3216) * removed stale comment line * Revert "removed stale comment line" This reverts commit e0fa894. * removed stale comment line --------- Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Mehul Aggarwal <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Syed Ali Ul Hasan <[email protected]> Co-authored-by: harshk-89 <[email protected]> Co-authored-by: Amaan ali <[email protected]> Co-authored-by: Yugal Sadhwani <[email protected]> Co-authored-by: Pranav Nathe <[email protected]> Co-authored-by: prathmesh703 <[email protected]> Co-authored-by: Nivedita <[email protected]>
What kind of change does this PR introduce?
Refactoring
Issue Number:
Fixes #2552
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Refactored src/screens/FundCampaignPledge/FundCampaignPledge.test.tsx to FundCampaignPledge.spec.tsx
Does this PR introduce a breaking change?
No
Other information
N/A
Have you read the contributing guide?
Yes
Summary by CodeRabbit
FundCampaignPledgecomponent to use Vitest mocking framework